All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: reiserfs-devel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-bluetooth@vger.kernel.org, debora@linux.vnet.ibm.com,
	linux-i2c@vger.kernel.org,
	"Justin P. Mattock" <justinmattock@gmail.com>,
	linux1394-devel@lists.sourceforge.net,
	linux-media@vger.kernel.org
Subject: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used
Date: Mon, 14 Jun 2010 13:26:47 -0700	[thread overview]
Message-ID: <1276547208-26569-8-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1276547208-26569-1-git-send-email-justinmattock@gmail.com>

Temporary fix until something is resolved
to fix the below warning:
  CC [M]  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used
 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/ieee1394/sbp2.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 4565cb5..fcf8bd5 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
 
 	management_agent_addr = 0;
 	unit_characteristics = 0;
+	if (!unit_characteristics)
+		unit_characteristics = 0;
 	firmware_revision = SBP2_ROM_VALUE_MISSING;
 	model = ud->flags & UNIT_DIRECTORY_MODEL_ID ?
 				ud->model_id : SBP2_ROM_VALUE_MISSING;
-- 
1.7.1.rc1.21.gf3bd6


------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo

WARNING: multiple messages have this Message-ID (diff)
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	clemens@ladisch.de, debora@linux.vnet.ibm.com,
	dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net,
	linux-media@vger.kernel.org,
	"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used
Date: Mon, 14 Jun 2010 13:26:47 -0700	[thread overview]
Message-ID: <1276547208-26569-8-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1276547208-26569-1-git-send-email-justinmattock@gmail.com>

Temporary fix until something is resolved
to fix the below warning:
  CC [M]  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used
 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/ieee1394/sbp2.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 4565cb5..fcf8bd5 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -1356,6 +1356,8 @@ static void sbp2_parse_unit_directory(struct sbp2_lu *lu,
 
 	management_agent_addr = 0;
 	unit_characteristics = 0;
+	if (!unit_characteristics)
+		unit_characteristics = 0;
 	firmware_revision = SBP2_ROM_VALUE_MISSING;
 	model = ud->flags & UNIT_DIRECTORY_MODEL_ID ?
 				ud->model_id : SBP2_ROM_VALUE_MISSING;
-- 
1.7.1.rc1.21.gf3bd6


  parent reply	other threads:[~2010-06-14 20:26 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 20:26 [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 1/8]reiserfs:stree.c Fix variable set but not used Justin P. Mattock
     [not found]   ` <1276547208-26569-2-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 20:48     ` Nick Bowler
2010-06-14 20:48       ` Nick Bowler
     [not found]       ` <20100614204805.GA12589-7BP4RkwGw0uXmMXjJBpWqg@public.gmane.org>
2010-06-14 21:09         ` Justin P. Mattock
2010-06-14 21:09         ` Justin P. Mattock
2010-06-14 21:09           ` Justin P. Mattock
2010-06-14 21:05     ` Edward Shishkin
2010-06-14 21:05       ` Edward Shishkin
     [not found]       ` <4C1699AA.3000900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 21:21         ` Justin P. Mattock
2010-06-14 21:21           ` Justin P. Mattock
2010-06-14 21:47           ` Edward Shishkin
     [not found]             ` <4C16A372.6020604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 22:50               ` Justin P. Mattock
2010-06-14 22:50                 ` Justin P. Mattock
2010-06-14 23:07                 ` Stefan Richter
     [not found]                   ` <tkrat.d7bea45e7dbad972-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org>
2010-06-15  0:01                     ` Justin P. Mattock
2010-06-15  0:01                       ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-15  0:24   ` Gustavo F. Padovan
2010-06-15  0:24     ` Gustavo F. Padovan
2010-06-14 20:26 ` [PATCH 3/8]char/hpet.c Fix variable 'hpet' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
     [not found]   ` <1276547208-26569-5-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15  0:13     ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15  0:13       ` Valdis.Kletnieks
2010-06-15  2:12       ` Justin P. Mattock
2010-06-15  2:12         ` Justin P. Mattock
     [not found]         ` <4C16E18F.9050901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15  3:49           ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15  3:49             ` Valdis.Kletnieks
2010-06-15  3:56             ` Justin P. Mattock
2010-06-15  5:29               ` Peter Stuge
2010-06-15  5:58                 ` Justin P. Mattock
2010-06-15  5:58                   ` Justin P. Mattock
2010-06-15  6:57                   ` Stefan Richter
2010-06-15  7:27                     ` Justin P. Mattock
2010-06-15  7:56                       ` Stefan Richter
2010-06-15  8:30                         ` Justin P. Mattock
     [not found]                 ` <20100615052944.7746.qmail-Y+HMSxxDrH8@public.gmane.org>
2010-06-15  5:58                   ` Justin P. Mattock
2010-06-15  9:19                   ` Jean Delvare
2010-06-15  9:19                     ` Jean Delvare
2010-06-15  9:19                     ` Jean Delvare
2010-06-15  9:41                     ` Justin P. Mattock
2010-06-15  9:41                       ` Justin P. Mattock
2010-06-15 18:53     ` Sergey V.
2010-06-15 18:53       ` Sergey V.
     [not found]       ` <201006152253.44326.sftp.mtuci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 19:36         ` Justin P. Mattock
2010-06-15 19:36           ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
2010-06-14 20:53   ` Jean Delvare
2010-06-14 21:06     ` Justin P. Mattock
     [not found]       ` <4C1699C4.3010809-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 11:43         ` Jean Delvare
2010-06-15 11:43           ` Jean Delvare
2010-06-15 11:43           ` Jean Delvare
2010-06-15 16:51           ` Justin P. Mattock
2010-06-14 21:28     ` David Daney
2010-06-15 11:40       ` Jean Delvare
2010-06-15 11:40         ` Jean Delvare
     [not found]         ` <20100615134039.6ccfc17a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-06-15 16:20           ` David Daney
2010-06-15 16:20             ` David Daney
     [not found]             ` <4C17A857.8030306-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-06-16  9:45               ` Jean Delvare
2010-06-16  9:45                 ` Jean Delvare
2010-06-16  9:45                 ` Jean Delvare
2010-06-14 20:26 ` Justin P. Mattock [this message]
2010-06-14 20:26   ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' " Justin P. Mattock
2010-06-14 21:44   ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-14 22:35     ` Justin P. Mattock
2010-06-14 23:22       ` Stefan Richter
2010-06-14 23:58         ` Justin P. Mattock
2010-06-15  0:08         ` (no subject) Stefan Richter
2010-06-15  0:00       ` [PATCH] ieee1394: remove unused variables Stefan Richter
2010-06-15  0:05       ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-15  1:59         ` Justin P. Mattock
     [not found]   ` <1276547208-26569-8-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 11:38     ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Jean Delvare
2010-06-15 11:38       ` Jean Delvare
2010-06-15 11:38       ` Jean Delvare
2010-06-15 16:52       ` Justin P. Mattock
2010-06-15 16:52         ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' " Justin P. Mattock
2010-06-14 20:26   ` Justin P. Mattock
     [not found]   ` <1276547208-26569-9-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15  5:16     ` Mauro Carvalho Chehab
2010-06-15  5:16       ` Mauro Carvalho Chehab
     [not found]       ` <4C170CA4.2020805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-15  5:37         ` Justin P. Mattock
2010-06-15  5:37           ` Justin P. Mattock
2010-06-15  5:50       ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276547208-26569-8-git-send-email-justinmattock@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=debora@linux.vnet.ibm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.