From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, clemens@ladisch.de,
debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org,
linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' set but not used
Date: Mon, 14 Jun 2010 21:24:49 -0300 [thread overview]
Message-ID: <20100615001444.GC9203@vigoh> (raw)
In-Reply-To: <1276547208-26569-3-git-send-email-justinmattock@gmail.com>
Hi Justin,
* Justin P. Mattock <justinmattock@gmail.com> [2010-06-14 13:26:42 -0700]:
> Im getting this while building:
> CC [M] drivers/bluetooth/hci_ldisc.o
> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_send_frame':
> drivers/bluetooth/hci_ldisc.c:213:21: warning: variable 'tty' set but not used
>
> the below fixed it for me, but am not sure if
> it's correct.
The fix is correct, you just need to fix the trailing whitespace
problem and resend it.
Also we use "Bluetooth:" as part of the commit message on the bluetooth
subsystem. For example:
"Bluetooth: Remove set but not used varible 'tty'
Or something like that.
--
Gustavo F. Padovan
http://padovan.org
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo F. Padovan" <gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>
To: "Justin P. Mattock"
<justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
clemens-P6GI/4k7KOmELgA04lAiVw@public.gmane.org,
debora-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux1394-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' set but not used
Date: Mon, 14 Jun 2010 21:24:49 -0300 [thread overview]
Message-ID: <20100615001444.GC9203@vigoh> (raw)
In-Reply-To: <1276547208-26569-3-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Justin,
* Justin P. Mattock <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [2010-06-14 13:26:42 -0700]:
> Im getting this while building:
> CC [M] drivers/bluetooth/hci_ldisc.o
> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_send_frame':
> drivers/bluetooth/hci_ldisc.c:213:21: warning: variable 'tty' set but not used
>
> the below fixed it for me, but am not sure if
> it's correct.
The fix is correct, you just need to fix the trailing whitespace
problem and resend it.
Also we use "Bluetooth:" as part of the commit message on the bluetooth
subsystem. For example:
"Bluetooth: Remove set but not used varible 'tty'
Or something like that.
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-06-15 0:24 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 20:26 [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 1/8]reiserfs:stree.c Fix variable set but not used Justin P. Mattock
[not found] ` <1276547208-26569-2-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 20:48 ` Nick Bowler
2010-06-14 20:48 ` Nick Bowler
[not found] ` <20100614204805.GA12589-7BP4RkwGw0uXmMXjJBpWqg@public.gmane.org>
2010-06-14 21:09 ` Justin P. Mattock
2010-06-14 21:09 ` Justin P. Mattock
2010-06-14 21:09 ` Justin P. Mattock
2010-06-14 21:05 ` Edward Shishkin
2010-06-14 21:05 ` Edward Shishkin
[not found] ` <4C1699AA.3000900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 21:21 ` Justin P. Mattock
2010-06-14 21:21 ` Justin P. Mattock
2010-06-14 21:47 ` Edward Shishkin
[not found] ` <4C16A372.6020604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-14 22:50 ` Justin P. Mattock
2010-06-14 22:50 ` Justin P. Mattock
2010-06-14 23:07 ` Stefan Richter
[not found] ` <tkrat.d7bea45e7dbad972-MtYdepGKPcBMYopoZt5u/LNAH6kLmebB@public.gmane.org>
2010-06-15 0:01 ` Justin P. Mattock
2010-06-15 0:01 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-15 0:24 ` Gustavo F. Padovan [this message]
2010-06-15 0:24 ` Gustavo F. Padovan
2010-06-14 20:26 ` [PATCH 3/8]char/hpet.c Fix variable 'hpet' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
[not found] ` <1276547208-26569-5-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 0:13 ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15 0:13 ` Valdis.Kletnieks
2010-06-15 2:12 ` Justin P. Mattock
2010-06-15 2:12 ` Justin P. Mattock
[not found] ` <4C16E18F.9050901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 3:49 ` Valdis.Kletnieks-PjAqaU27lzQ
2010-06-15 3:49 ` Valdis.Kletnieks
2010-06-15 3:56 ` Justin P. Mattock
2010-06-15 5:29 ` Peter Stuge
[not found] ` <20100615052944.7746.qmail-Y+HMSxxDrH8@public.gmane.org>
2010-06-15 5:58 ` Justin P. Mattock
2010-06-15 9:19 ` Jean Delvare
2010-06-15 9:19 ` Jean Delvare
2010-06-15 9:19 ` Jean Delvare
2010-06-15 9:19 ` Jean Delvare
2010-06-15 9:41 ` Justin P. Mattock
2010-06-15 9:41 ` Justin P. Mattock
2010-06-15 5:58 ` Justin P. Mattock
2010-06-15 5:58 ` Justin P. Mattock
2010-06-15 6:57 ` Stefan Richter
2010-06-15 7:27 ` Justin P. Mattock
2010-06-15 7:56 ` Stefan Richter
2010-06-15 8:30 ` Justin P. Mattock
2010-06-15 18:53 ` Sergey V.
2010-06-15 18:53 ` Sergey V.
[not found] ` <201006152253.44326.sftp.mtuci-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 19:36 ` Justin P. Mattock
2010-06-15 19:36 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 20:53 ` Jean Delvare
2010-06-14 21:06 ` Justin P. Mattock
[not found] ` <4C1699C4.3010809-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 11:43 ` Jean Delvare
2010-06-15 11:43 ` Jean Delvare
2010-06-15 11:43 ` Jean Delvare
2010-06-15 11:43 ` Jean Delvare
2010-06-15 16:51 ` Justin P. Mattock
2010-06-14 21:28 ` David Daney
2010-06-15 11:40 ` Jean Delvare
2010-06-15 11:40 ` Jean Delvare
[not found] ` <20100615134039.6ccfc17a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-06-15 16:20 ` David Daney
2010-06-15 16:20 ` David Daney
[not found] ` <4C17A857.8030306-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2010-06-16 9:45 ` Jean Delvare
2010-06-16 9:45 ` Jean Delvare
2010-06-16 9:45 ` Jean Delvare
2010-06-16 9:45 ` Jean Delvare
2010-06-14 20:26 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
2010-06-14 21:44 ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-14 22:35 ` Justin P. Mattock
2010-06-14 23:22 ` Stefan Richter
2010-06-14 23:58 ` Justin P. Mattock
2010-06-15 0:08 ` (no subject) Stefan Richter
2010-06-15 0:00 ` [PATCH] ieee1394: remove unused variables Stefan Richter
2010-06-15 0:05 ` [PATCH] ieee1394: sbp2: remove unused code Stefan Richter
2010-06-15 1:59 ` Justin P. Mattock
[not found] ` <1276547208-26569-8-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 11:38 ` [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used Jean Delvare
2010-06-15 11:38 ` Jean Delvare
2010-06-15 11:38 ` Jean Delvare
2010-06-15 16:52 ` Justin P. Mattock
2010-06-15 16:52 ` Justin P. Mattock
2010-06-14 20:26 ` [PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' " Justin P. Mattock
2010-06-14 20:26 ` Justin P. Mattock
[not found] ` <1276547208-26569-9-git-send-email-justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 5:16 ` Mauro Carvalho Chehab
2010-06-15 5:16 ` Mauro Carvalho Chehab
[not found] ` <4C170CA4.2020805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-15 5:37 ` Justin P. Mattock
2010-06-15 5:37 ` Justin P. Mattock
2010-06-15 5:50 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615001444.GC9203@vigoh \
--to=gustavo@padovan.org \
--cc=clemens@ladisch.de \
--cc=debora@linux.vnet.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=justinmattock@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.