From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Maurus Cuelenaere <mcuelenaere@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Invert speaker enabling behaviour in SmartQ sound driver
Date: Tue, 06 Jul 2010 09:07:36 +0100 [thread overview]
Message-ID: <1278403656.3103.10.camel@odin> (raw)
In-Reply-To: <4c3088ad.487e0e0a.3402.6e62@mx.google.com>
On Sun, 2010-07-04 at 15:12 +0200, Maurus Cuelenaere wrote:
> The speaker was enabled when the headphone was plugged in, which isn't the
> wanted behaviour so correct this.
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> sound/soc/s3c24xx/smartq_wm8987.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/smartq_wm8987.c b/sound/soc/s3c24xx/smartq_wm8987.c
> index c90ef96..b480348 100644
> --- a/sound/soc/s3c24xx/smartq_wm8987.c
> +++ b/sound/soc/s3c24xx/smartq_wm8987.c
> @@ -112,7 +112,6 @@ static struct snd_soc_jack_pin smartq_jack_pins[] = {
> {
> .pin = "Internal Speaker",
> .mask = SND_JACK_HEADPHONE,
> - .invert = true,
> },
> };
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
WARNING: multiple messages have this Message-ID (diff)
From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: Invert speaker enabling behaviour in SmartQ sound driver
Date: Tue, 06 Jul 2010 09:07:36 +0100 [thread overview]
Message-ID: <1278403656.3103.10.camel@odin> (raw)
In-Reply-To: <4c3088ad.487e0e0a.3402.6e62@mx.google.com>
On Sun, 2010-07-04 at 15:12 +0200, Maurus Cuelenaere wrote:
> The speaker was enabled when the headphone was plugged in, which isn't the
> wanted behaviour so correct this.
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> sound/soc/s3c24xx/smartq_wm8987.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/smartq_wm8987.c b/sound/soc/s3c24xx/smartq_wm8987.c
> index c90ef96..b480348 100644
> --- a/sound/soc/s3c24xx/smartq_wm8987.c
> +++ b/sound/soc/s3c24xx/smartq_wm8987.c
> @@ -112,7 +112,6 @@ static struct snd_soc_jack_pin smartq_jack_pins[] = {
> {
> .pin = "Internal Speaker",
> .mask = SND_JACK_HEADPHONE,
> - .invert = true,
> },
> };
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-07-06 8:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 0:46 [PATCH 2/3] ASoC: Add SmartQ sound driver Maurus Cuelenaere
2010-07-03 0:46 ` Maurus Cuelenaere
2010-07-04 9:05 ` Mark Brown
2010-07-04 9:05 ` Mark Brown
2010-07-04 9:19 ` Maurus Cuelenaere
2010-07-04 9:19 ` Maurus Cuelenaere
2010-07-04 9:42 ` Mark Brown
2010-07-04 9:42 ` Mark Brown
2010-07-04 9:45 ` Maurus Cuelenaere
2010-07-04 9:45 ` Maurus Cuelenaere
2010-07-04 10:03 ` Maurus Cuelenaere
2010-07-04 10:03 ` Maurus Cuelenaere
2010-07-04 13:01 ` Mark Brown
2010-07-04 13:01 ` Mark Brown
2010-07-04 13:12 ` [PATCH] ASoC: Invert speaker enabling behaviour in " Maurus Cuelenaere
2010-07-04 13:12 ` Maurus Cuelenaere
2010-07-06 8:07 ` Liam Girdwood [this message]
2010-07-06 8:07 ` [alsa-devel] " Liam Girdwood
2010-07-06 14:54 ` Mark Brown
2010-07-06 14:54 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278403656.3103.10.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mcuelenaere@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.