From: Maurus Cuelenaere <mcuelenaere@gmail.com>
To: alsa-devel@alsa-project.org
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/3] ASoC: Add SmartQ sound driver
Date: Sun, 04 Jul 2010 12:03:33 +0200 [thread overview]
Message-ID: <4C305C75.1060305@gmail.com> (raw)
In-Reply-To: <4c2e8856.487e0e0a.3bb5.3ec0@mx.google.com>
Op 03-07-10 02:46, Maurus Cuelenaere schreef:
> +static struct snd_soc_jack_pin smartq_jack_pins[] = {
> + /* Disable speaker when headphone is plugged in */
> + {
> + .pin = "Internal Speaker",
> + .mask = SND_JACK_HEADPHONE,
> + .invert = true,
> + },
> +};
Hmm I just discovered that this .invert should be false (guess I didn't test enough), should I resubmit this patch or submit an incremental one?
--
Maurus Cuelenaere
WARNING: multiple messages have this Message-ID (diff)
From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: Add SmartQ sound driver
Date: Sun, 04 Jul 2010 12:03:33 +0200 [thread overview]
Message-ID: <4C305C75.1060305@gmail.com> (raw)
In-Reply-To: <4c2e8856.487e0e0a.3bb5.3ec0@mx.google.com>
Op 03-07-10 02:46, Maurus Cuelenaere schreef:
> +static struct snd_soc_jack_pin smartq_jack_pins[] = {
> + /* Disable speaker when headphone is plugged in */
> + {
> + .pin = "Internal Speaker",
> + .mask = SND_JACK_HEADPHONE,
> + .invert = true,
> + },
> +};
Hmm I just discovered that this .invert should be false (guess I didn't test enough), should I resubmit this patch or submit an incremental one?
--
Maurus Cuelenaere
next prev parent reply other threads:[~2010-07-04 10:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 0:46 [PATCH 2/3] ASoC: Add SmartQ sound driver Maurus Cuelenaere
2010-07-03 0:46 ` Maurus Cuelenaere
2010-07-04 9:05 ` Mark Brown
2010-07-04 9:05 ` Mark Brown
2010-07-04 9:19 ` Maurus Cuelenaere
2010-07-04 9:19 ` Maurus Cuelenaere
2010-07-04 9:42 ` Mark Brown
2010-07-04 9:42 ` Mark Brown
2010-07-04 9:45 ` Maurus Cuelenaere
2010-07-04 9:45 ` Maurus Cuelenaere
2010-07-04 10:03 ` Maurus Cuelenaere [this message]
2010-07-04 10:03 ` Maurus Cuelenaere
2010-07-04 13:01 ` Mark Brown
2010-07-04 13:01 ` Mark Brown
2010-07-04 13:12 ` [PATCH] ASoC: Invert speaker enabling behaviour in " Maurus Cuelenaere
2010-07-04 13:12 ` Maurus Cuelenaere
2010-07-06 8:07 ` [alsa-devel] " Liam Girdwood
2010-07-06 8:07 ` Liam Girdwood
2010-07-06 14:54 ` Mark Brown
2010-07-06 14:54 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C305C75.1060305@gmail.com \
--to=mcuelenaere@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.