Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues

["François Revol" <revol@free.fr>]

> >> Unresolved issues include that AIO is detected, and as a
> > > consequence
> >
> > Then the test is buggy as we don't have AIO in Haiku that I know of
> > :)
>
> Hm, the so-called AIO check is rather a pthreads check:
>
> #include <pthread.h>
> int main(void) { pthread_mutex_t lock;  return 0; }
>
> If that compiles, a working -lpthread is assumed. It's buggy in
> itself
> because it first sets AIOLIBS="", then compiles with unchanged empty
> $AIOLIBS and then sets AIOLIBS="-lpthread".
>
> >
> >> AIOLIBS is set to -lpthread but that is not available on Haiku.
> >
> > Well we should have a pthread lib available though...
>
> It's part of libroot.so, I thought, and thus referenced without extra
> linker arguments.

Not sure we really want to keep it that way in Haiku then...

> > Another big issue that I mentionned earlier here is the widely used
> > assumption that error codes are positive, which is not the case for
> > BeOS and Haiku.
> > Not fixing this will result in a dangerous binary.
>
> Thanks for the reminder. But that also reminds me, you wanted to
> supply a patch for that! :)

You can always beat me to it.

François.