From: Avi Kivity <avi@redhat.com>
To: "François Revol" <revol@free.fr>
Cc: haikuports-devs@ports.haiku-files.org, qemu-devel@nongnu.org
Subject: Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues
Date: Mon, 09 Mar 2009 16:33:23 +0200 [thread overview]
Message-ID: <49B528B3.9020800@redhat.com> (raw)
In-Reply-To: <3165008770-BeMail@laptop>
François Revol wrote:
>> We could define a qemu_errno() which returns errno converted to
>> positive
>> numbers. While it will touch a lot of places, I don't think it can
>> be
>> considered invasive.
>>
>
> I'm used to using the opposite, RETERR() returning always negative
> codes from either errno or E*, and it works quite well.
>
> I don't see the point in making stuff positive to return them negated.
>
Changing errno to qemu_errno() is not an invasive change (at least, not
much). Adding a RETERR() is, with significant chance for regressions.
> Besides, one of the error codes in BeOS & Haiku will certainly overflow
> on 32bit (B_NO_MEMORY = B_GENERAL_ERROR_BASE = LONG_MIN).
>
qemu_errno() on Haiku could change it to something else.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-09 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 14:08 [Qemu-devel] [PATCH] [RFC] Haiku host support and general configure issues Andreas Färber
2009-02-28 17:08 ` [Qemu-devel] " François Revol
2009-02-28 18:31 ` Andreas Färber
2009-02-28 19:01 ` [HaikuPorts-devs] " François Revol
2009-02-28 20:26 ` Jamie Lokier
2009-02-28 20:32 ` François Revol
2009-03-08 18:15 ` Anthony Liguori
2009-03-08 18:41 ` [HaikuPorts-devs] " François Revol
2009-03-09 8:40 ` Avi Kivity
2009-03-09 14:14 ` [HaikuPorts-devs] " François Revol
2009-03-09 14:33 ` Avi Kivity [this message]
2009-03-09 15:39 ` François Revol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B528B3.9020800@redhat.com \
--to=avi@redhat.com \
--cc=haikuports-devs@ports.haiku-files.org \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.