[Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues

["François Revol" <revol@free.fr>]

> We have undocumented --extra-cflags= and --extra-ldflags= options
> that
> don't work as expected. They are ignored by all the configure tests,
> so it seems there is no direct equivalent to autoconf's CPPFLAGS to
> pass in additional header include paths. The OS_CFLAGS come closest,
> but they are ignored for some of the tests, too. Any preferences how
> to fix this?

Ideally those shouldn't be needed anyway.

> The optional curses support relies on -lcurses but it's called
> libncurses.a on Haiku, so add a check for -lncurses if -lcurses
> fails.
> It is then detected.

ncurses is a different implementation but should be compatible AFAIK.

> Unresolved issues include that AIO is detected, and as a consequence

Then the test is buggy as we don't have AIO in Haiku that I know of :)

> AIOLIBS is set to -lpthread but that is not available on Haiku.

Well we should have a pthread lib available though...

> The code still does not link qemu-img due to an unresolved symbol _IO
> in nbd code. Not sure if that's a missing check in QEMU or an issue
> in
> Haiku? There doesn't appear to be a switch to disable NBD altogether,
> so this seems like a blocker for now.

Another big issue that I mentionned earlier here is the widely used
assumption that error codes are positive, which is not the case for
BeOS and Haiku.
Not fixing this will result in a dangerous binary.

François.