From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Tejun Heo <tj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 10/14] scsi: osd: fix device_register() error handling
Date: Sun, 19 Sep 2010 12:55:07 +0000 [thread overview]
Message-ID: <1284900907-24621-1-git-send-email-segooon@gmail.com> (raw)
If device_register() fails then call put_device().
See comment to device_register.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
compile tested.
drivers/scsi/osd/osd_uld.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
index cefb2c0..3e0edc2 100644
--- a/drivers/scsi/osd/osd_uld.c
+++ b/drivers/scsi/osd/osd_uld.c
@@ -474,7 +474,7 @@ static int osd_probe(struct device *dev)
error = device_register(&oud->class_dev);
if (error) {
OSD_ERR("device_register failed => %d\n", error);
- goto err_put_cdev;
+ goto err_put_device;
}
get_device(&oud->class_dev);
@@ -482,6 +482,8 @@ static int osd_probe(struct device *dev)
OSD_INFO("osd_probe %s\n", disk->disk_name);
return 0;
+err_put_device:
+ put_device(&oud->class_dev);
err_put_cdev:
cdev_del(&oud->cdev);
err_put_disk:
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Tejun Heo <tj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 10/14] scsi: osd: fix device_register() error handling
Date: Sun, 19 Sep 2010 16:55:07 +0400 [thread overview]
Message-ID: <1284900907-24621-1-git-send-email-segooon@gmail.com> (raw)
If device_register() fails then call put_device().
See comment to device_register.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
compile tested.
drivers/scsi/osd/osd_uld.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
index cefb2c0..3e0edc2 100644
--- a/drivers/scsi/osd/osd_uld.c
+++ b/drivers/scsi/osd/osd_uld.c
@@ -474,7 +474,7 @@ static int osd_probe(struct device *dev)
error = device_register(&oud->class_dev);
if (error) {
OSD_ERR("device_register failed => %d\n", error);
- goto err_put_cdev;
+ goto err_put_device;
}
get_device(&oud->class_dev);
@@ -482,6 +482,8 @@ static int osd_probe(struct device *dev)
OSD_INFO("osd_probe %s\n", disk->disk_name);
return 0;
+err_put_device:
+ put_device(&oud->class_dev);
err_put_cdev:
cdev_del(&oud->cdev);
err_put_disk:
--
1.7.0.4
next reply other threads:[~2010-09-19 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 12:55 Vasiliy Kulikov [this message]
2010-09-19 12:55 ` [PATCH 10/14] scsi: osd: fix device_register() error handling Vasiliy Kulikov
2010-09-19 14:26 ` Dan Carpenter
2010-09-19 14:26 ` Dan Carpenter
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-19 15:12 ` Dan Carpenter
2010-09-19 15:12 ` Dan Carpenter
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-20 11:58 ` James Bottomley
2010-09-20 11:58 ` James Bottomley
2010-09-20 15:10 ` Greg KH
2010-09-20 15:10 ` Greg KH
2010-09-20 15:13 ` Greg KH
2010-09-20 15:13 ` Greg KH
2010-09-20 15:21 ` James Bottomley
2010-09-20 15:21 ` James Bottomley
2010-09-20 15:42 ` Boaz Harrosh
2010-09-20 15:42 ` Boaz Harrosh
2010-09-20 15:55 ` James Bottomley
2010-09-20 15:55 ` James Bottomley
2010-09-20 16:31 ` Boaz Harrosh
2010-09-20 16:31 ` Boaz Harrosh
2010-09-19 15:32 ` Boaz Harrosh
2010-09-19 15:32 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284900907-24621-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=arnd@arndb.de \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.