From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Tejun Heo <tj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
cornelia.huck@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/14] scsi: osd: fix device_register() error handling
Date: Sun, 19 Sep 2010 15:12:58 +0000 [thread overview]
Message-ID: <20100919151258.GG6236@bicker> (raw)
In-Reply-To: <20100919143948.GA4866@albatros>
On Sun, Sep 19, 2010 at 06:39:50PM +0400, Vasiliy Kulikov wrote:
> >
> > If that's the case then the put_device() should be called infront of the
> > goto.
>
> As it is the last call that may fail, it is redundant. Or you mean for future,
> if someone adds more code after device_register()?
>
Yes. I mean in the future.
regards,
dan carpenter
>
> Thanks,
> --
> Vasiliy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Tejun Heo <tj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
cornelia.huck@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/14] scsi: osd: fix device_register() error handling
Date: Sun, 19 Sep 2010 17:12:58 +0200 [thread overview]
Message-ID: <20100919151258.GG6236@bicker> (raw)
In-Reply-To: <20100919143948.GA4866@albatros>
On Sun, Sep 19, 2010 at 06:39:50PM +0400, Vasiliy Kulikov wrote:
> >
> > If that's the case then the put_device() should be called infront of the
> > goto.
>
> As it is the last call that may fail, it is redundant. Or you mean for future,
> if someone adds more code after device_register()?
>
Yes. I mean in the future.
regards,
dan carpenter
>
> Thanks,
> --
> Vasiliy
next prev parent reply other threads:[~2010-09-19 15:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 12:55 [PATCH 10/14] scsi: osd: fix device_register() error handling Vasiliy Kulikov
2010-09-19 12:55 ` Vasiliy Kulikov
2010-09-19 14:26 ` Dan Carpenter
2010-09-19 14:26 ` Dan Carpenter
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-19 15:12 ` Dan Carpenter [this message]
2010-09-19 15:12 ` Dan Carpenter
2010-09-19 14:39 ` Vasiliy Kulikov
2010-09-20 11:58 ` James Bottomley
2010-09-20 11:58 ` James Bottomley
2010-09-20 15:10 ` Greg KH
2010-09-20 15:10 ` Greg KH
2010-09-20 15:13 ` Greg KH
2010-09-20 15:13 ` Greg KH
2010-09-20 15:21 ` James Bottomley
2010-09-20 15:21 ` James Bottomley
2010-09-20 15:42 ` Boaz Harrosh
2010-09-20 15:42 ` Boaz Harrosh
2010-09-20 15:55 ` James Bottomley
2010-09-20 15:55 ` James Bottomley
2010-09-20 16:31 ` Boaz Harrosh
2010-09-20 16:31 ` Boaz Harrosh
2010-09-19 15:32 ` Boaz Harrosh
2010-09-19 15:32 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100919151258.GG6236@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=arnd@arndb.de \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=segooon@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.