Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value

[Ben Hutchings <bhutchings@solarflare.com>]

On Mon, 2010-09-20 at 20:54 +0200, Eric Dumazet wrote:
> Le lundi 20 septembre 2010 à 19:43 +0100, Ben Hutchings a écrit :
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> >  drivers/net/sfc/efx.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
> > index 4a1c93f..48e2bf4 100644
> > --- a/drivers/net/sfc/efx.c
> > +++ b/drivers/net/sfc/efx.c
> > @@ -1315,6 +1315,7 @@ static int efx_probe_nic(struct efx_nic *efx)
> >  
> >  	efx_set_channels(efx);
> >  	efx->net_dev->real_num_tx_queues = efx->n_tx_channels;
> > +	efx->net_dev->num_rx_queues = efx->n_rx_channels;
> >  
> >  	/* Initialise the interrupt moderation settings */
> >  	efx_init_irq_moderation(efx, tx_irq_mod_usec, rx_irq_mod_usec, true);
> > -- 
> > 1.7.2.1
> > 
> > 
> > 
> 
> Interesting, but why ?
> 
> No other driver does this AFAIK...

If RPS is enabled there's a separate kobject for each RX queue.  Those
other drivers probably should be setting it.

Oh, but this only exists if CONFIG_RPS is enabled.  I think we need an
inline function for setting this.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.