Re: [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37

[Ben Hutchings <bhutchings@solarflare.com>]

On Tue, 2010-09-21 at 16:23 -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 21 Sep 2010 14:58:27 -0700 (PDT)
> 
> > From: Ben Hutchings <bhutchings@solarflare.com>
> > Date: Mon, 20 Sep 2010 19:40:56 +0100
> > 
> >> This series adds Ethernet-level filtering and explicit filter clearing
> >> to the ethtool RX n-tuple interface, and implements it in the sfc
> >> driver.
> >> 
> >> There is a cleanup patch on the end which is preparation for the
> >> following RFC patch series but is worthwhile anyway.
> >> 
> >> Ben Hutchings (8):
> >>   ethtool: Define RX n-tuple action to clear a rule
> >>   ethtool: Add Ethernet MAC-level filtering/steering
> >>   ethtool: Allocate register dump buffer with vmalloc()
> >>   sfc: Add filter table management
> >>   sfc: Implement the ethtool RX n-tuple control functions
> >>   sfc: Include RX IP filter table in register dump
> >>   sfc: Set net_device::num_rx_queues once we know the correct value
> >>   sfc: Clean up and correct comments on efx_monitor()
> > 
> > All applied except patch #7 as noted in the thread for that patch.
> 
> Ben, just FYI, I had to add "linux/vmalloc.h" includes to both
> net/core/ethtool.c and drivers/net/sfc/net_driver.h otherwise
> the build breaks on some architectures.
> 
> x86 can be a really bad arch to validates builds on because it
> currently gets vmalloc.h implicitly by some of it's core header files.
> 
> In particular, asm/io.h :-/

Thanks, and sorry for missing this.  We have some SPARC systems that I
could potentially test on but I think they're limited to running
Solaris.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.