From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value
Date: Wed, 22 Sep 2010 16:28:47 +0100 [thread overview]
Message-ID: <1285169327.2279.3.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <20100921.183834.70182767.davem@davemloft.net>
On Tue, 2010-09-21 at 18:38 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Wed, 22 Sep 2010 02:31:36 +0100
>
> > Right, but we do need to have some way for drivers to specify the actual
> > number of RX queues.
>
> Ok, the problem stems merely from the fact that we only specify one
> "queue count" in alloc_netdev_mq(). We should specify two, one for
> TX and one for RX.
>
> So why not fix that instead of putting hacks into the drivers? :-)
That still doesn't solve the original problem, since drivers generally
won't know how many RX queues they should (or can) create until some
time after calling alloc_netdev_mq().
You know very well why we distinguish real_num_tx_queues and
num_tx_queues; what's so different about RX queues?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-09-22 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 18:40 [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 Ben Hutchings
2010-09-20 18:41 ` [PATCH net-next-2.6 1/8] ethtool: Define RX n-tuple action to clear a rule Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 2/8] ethtool: Add Ethernet MAC-level filtering/steering Ben Hutchings
2010-09-20 18:42 ` [PATCH net-next-2.6 3/8] ethtool: Allocate register dump buffer with vmalloc() Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 4/8] sfc: Add filter table management Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 5/8] sfc: Implement the ethtool RX n-tuple control functions Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 6/8] sfc: Include RX IP filter table in register dump Ben Hutchings
2010-09-20 18:43 ` [PATCH net-next-2.6 7/8] sfc: Set net_device::num_rx_queues once we know the correct value Ben Hutchings
2010-09-20 18:54 ` Eric Dumazet
2010-09-20 19:05 ` Ben Hutchings
2010-09-21 21:57 ` David Miller
2010-09-22 1:31 ` Ben Hutchings
2010-09-22 1:38 ` David Miller
2010-09-22 15:28 ` Ben Hutchings [this message]
2010-09-22 15:44 ` Eric Dumazet
2010-09-20 18:44 ` [PATCH net-next-2.6 8/8] sfc: Clean up and correct comments on efx_monitor() Ben Hutchings
2010-09-21 21:58 ` [PATCH net-next-2.6 0/8] sfc and ethtool changes for 2.6.37 David Miller
2010-09-21 23:23 ` David Miller
2010-09-22 15:27 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285169327.2279.3.camel@achroite.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.