From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: alsa-devel@alsa-project.org, Jassi Brar <jassi.brar@samsung.com>,
Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [patch] ASoC: soc: snprintf() doesn't return negative
Date: Mon, 11 Oct 2010 11:07:47 +0100 [thread overview]
Message-ID: <1286791667.3306.0.camel@odin> (raw)
In-Reply-To: <20101011035416.GD5851@bicker>
On Mon, 2010-10-11 at 05:54 +0200, Dan Carpenter wrote:
> In user space snprintf() returns negative on errors but the kernel
> version only returns positives. It could potentially return sizes
> larger than the size of the buffer so we should check for that.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: alsa-devel@alsa-project.org, Jassi Brar <jassi.brar@samsung.com>,
Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: [patch] ASoC: soc: snprintf() doesn't return negative
Date: Mon, 11 Oct 2010 10:07:47 +0000 [thread overview]
Message-ID: <1286791667.3306.0.camel@odin> (raw)
In-Reply-To: <20101011035416.GD5851@bicker>
On Mon, 2010-10-11 at 05:54 +0200, Dan Carpenter wrote:
> In user space snprintf() returns negative on errors but the kernel
> version only returns positives. It could potentially return sizes
> larger than the size of the buffer so we should check for that.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-10-11 10:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 3:54 [patch] ASoC: soc: snprintf() doesn't return negative Dan Carpenter
2010-10-11 3:54 ` Dan Carpenter
2010-10-11 10:07 ` Liam Girdwood [this message]
2010-10-11 10:07 ` Liam Girdwood
2010-10-11 10:40 ` Mark Brown
2010-10-11 10:40 ` Mark Brown
2010-10-11 16:40 ` Dan Carpenter
2010-10-11 16:40 ` Dan Carpenter
2010-10-11 16:40 ` Dan Carpenter
2010-10-11 18:51 ` Mark Brown
2010-10-11 18:51 ` Mark Brown
2010-10-11 18:51 ` Mark Brown
2010-10-11 19:45 ` Dan Carpenter
2010-10-11 19:45 ` Dan Carpenter
2010-10-11 19:45 ` Dan Carpenter
2010-10-11 20:57 ` Takashi Iwai
2010-10-11 20:57 ` Takashi Iwai
2010-10-11 20:57 ` Takashi Iwai
2010-10-12 9:35 ` Mark Brown
2010-10-12 9:35 ` Mark Brown
2010-10-12 9:35 ` Mark Brown
2010-10-12 9:49 ` Takashi Iwai
2010-10-12 9:49 ` Takashi Iwai
2010-10-12 9:49 ` Takashi Iwai
2010-10-12 9:56 ` Mark Brown
2010-10-12 9:56 ` Mark Brown
2010-10-12 9:56 ` Mark Brown
2010-10-12 10:40 ` Dan Carpenter
2010-10-12 10:40 ` Dan Carpenter
2010-10-12 10:40 ` Dan Carpenter
2010-10-11 21:11 ` Dan Carpenter
2010-10-11 21:11 ` Dan Carpenter
2010-10-11 21:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286791667.3306.0.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=error27@gmail.com \
--cc=jassi.brar@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.