From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] autoconfig.mk: avoid apostophes around hex values
Date: Sun, 17 Oct 2010 01:57:41 +0200 [thread overview]
Message-ID: <1287273462-14872-5-git-send-email-wd@denx.de> (raw)
In-Reply-To: <1286790310-5865-1-git-send-email-wd@denx.de>
When generating include/autoconfig.mk, hex numbers would be quoted.
This appears to be not a real problem, but caused some false positives
during automatic testing of the builds. Don't use apostophes for
decimal and hex numbers (nor or octal numbers).
Signed-off-by: Wolfgang Denk <wd@denx.de>
---
tools/scripts/define2mk.sed | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/scripts/define2mk.sed b/tools/scripts/define2mk.sed
index af40bfa..13e2845 100644
--- a/tools/scripts/define2mk.sed
+++ b/tools/scripts/define2mk.sed
@@ -18,8 +18,12 @@
s/="\(.*\)"$/=\1/;
# Concatenate string values
s/" *"//g;
- # Wrap non-numeral values with quotes
- s/=\(.*\?[^0-9].*\)$/=\"\1\"/;
+ # Assume strings as default - add quotes around values
+ s/=\(..*\)/="\1"/;
+ # but remove again from decimal numbers
+ s/="\([0-9][0-9]*\)"/=\1/;
+ # ... and from hex numbers
+ s/="\(0[Xx][0-9a-fA-F][0-9a-fA-F]*\)"/=\1/;
# Change '1' and empty values to "y" (not perfect, but
# supports conditional compilation in the makefiles
s/=$/=y/;
--
1.7.2.3
next prev parent reply other threads:[~2010-10-16 23:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 9:45 [U-Boot] [PATCH 0/3] Makefile cleanup Wolfgang Denk
2010-10-11 9:45 ` [U-Boot] [PATCH 1/3] Build: Add "board options" column to boards.cfg Wolfgang Denk
2010-10-11 9:45 ` [U-Boot] [PATCH 2/3] mkconfig: change CONFIG_MK_ prefix into plain CONFIG_ Wolfgang Denk
2010-10-11 19:17 ` Mike Frysinger
2010-10-12 19:46 ` Wolfgang Denk
2010-10-11 9:45 ` [U-Boot] [PATCH 3/3] Rename TEXT_BASE into CONFIG_SYS_TEXT_BASE Wolfgang Denk
2010-10-16 23:57 ` [U-Boot] [PATCH v2 0/5] Makefile cleanup Wolfgang Denk
2010-10-16 23:57 ` [U-Boot] [PATCH v2 1/5] Build: Add "board options" column to boards.cfg Wolfgang Denk
2010-10-17 0:12 ` Marek Vasut
2010-10-17 7:16 ` Wolfgang Denk
2010-10-17 0:13 ` Reinhard Meyer
2010-10-17 7:33 ` Wolfgang Denk
2010-10-18 20:00 ` Wolfgang Denk
2010-10-16 23:57 ` [U-Boot] [PATCH v2 2/5] mkconfig: change CONFIG_MK_ prefix into plain CONFIG_ Wolfgang Denk
2010-10-17 6:24 ` Mike Frysinger
2010-10-18 20:02 ` Wolfgang Denk
2010-10-16 23:57 ` [U-Boot] [PATCH v2 3/5] Rename TEXT_BASE into CONFIG_SYS_TEXT_BASE Wolfgang Denk
2010-10-18 20:08 ` Wolfgang Denk
2010-10-16 23:57 ` Wolfgang Denk [this message]
2010-10-17 6:23 ` [U-Boot] [PATCH v2 4/5] autoconfig.mk: avoid apostophes around hex values Mike Frysinger
2010-10-18 20:09 ` Wolfgang Denk
2010-10-16 23:57 ` [U-Boot] [PATCH v2 5/5] Makefile: move all Power Architecture boards into boards.cfg Wolfgang Denk
2010-10-18 20:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287273462-14872-5-git-send-email-wd@denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.