Re: [PATCH v3 06/13] OMAP3: DMA: hwmod: add system DMA

[Kevin Hilman <khilman@deeprootsystems.com>]

On Thu, 2010-11-04 at 08:30 -0400, Cousson, Benoit wrote:

[...]

> >>> Any better suggestion to handle this issue?
> >>
> >> Well, yes, use HWMOD_NO_IDLEST and remove idlest_reg_id&
> >> idlest_idle_bit entries in the omap2 structure.
> >>
> >> ST_SDMA is the standby status of the SDMA, but there is no
> >> idle status
> >> on that IP, so you cannot do anything.
> >> The standby will just reflect the activity of the master port of
> the
> >> DMA, but it will give you no information about the slave port
> >> and thus
> >> we do not have any module ready information.
> >
> > Thanks for the feedback.
> >
> > This change is introduced as per kevin's review comment at:
> > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg34278.html
> 
> Well this register is confusing, because he uses the same naming 
> convention but with a difference meaning:
> 
> ST_SDMA: System DMA standby status.
> - 0x0: System DMA is active.
> - 0x1: System DMA is in standby mode.
> 
> > I am ok to use "HWMOD_NO_IDLEST" if kevin also agrees

I agree.

> He will... Otherwise I will throw him into the New England Aquarium
> like Linus :-) 

...if he tried, I think he would end up in the fish tank before me. ;)

Kevin