All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature
Date: Wed, 10 Nov 2010 08:26:13 -0800	[thread overview]
Message-ID: <87hbfpcfh6.fsf@deeprootsystems.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DC1A7CBE@dbde02.ent.ti.com> (Manjunath Kondaiah G.'s message of "Wed, 10 Nov 2010 19:32:03 +0530")

"G, Manjunath Kondaiah" <manjugk@ti.com> writes:

[...]

>> > +	if (omap_type() == OMAP3430_REV_ES1_0)
>> > +		SET_DMA_ERRATA(DMA_ERRATA_i88);
>> > +
>> > +	/*
>> > +	 * Errata 3.2/3.3: sometimes 0 is returned if CSAC/CDAC is
>> 
>> This doesn't look like a unique errata identifier.  Chapter 3 
>> is usually
>> the 'Cautions' section, and I don't listed in either the 34xx (v5.9),
>> 36xx (v1.3) or 44xx (v1.3) errata docs under this number, and 
>> don't see
>> that number in either of the 24xx errata docs either.   
>> Please clarify.
>
> Even I tried to find this info from errata docs prior to migrating
> all errata's to generic errata handling. This code was exising earlier,
> hence I retained it "as is", no documentation exists for this errata.
>

Hmm, OK.  

According to the code, it seems to affect every IP execpt 1510, yet it's
not documented in any of the errata docs.  

I wonder what happens if it is removed?

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature
Date: Wed, 10 Nov 2010 08:26:13 -0800	[thread overview]
Message-ID: <87hbfpcfh6.fsf@deeprootsystems.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DC1A7CBE@dbde02.ent.ti.com> (Manjunath Kondaiah G.'s message of "Wed, 10 Nov 2010 19:32:03 +0530")

"G, Manjunath Kondaiah" <manjugk@ti.com> writes:

[...]

>> > +	if (omap_type() == OMAP3430_REV_ES1_0)
>> > +		SET_DMA_ERRATA(DMA_ERRATA_i88);
>> > +
>> > +	/*
>> > +	 * Errata 3.2/3.3: sometimes 0 is returned if CSAC/CDAC is
>> 
>> This doesn't look like a unique errata identifier.  Chapter 3 
>> is usually
>> the 'Cautions' section, and I don't listed in either the 34xx (v5.9),
>> 36xx (v1.3) or 44xx (v1.3) errata docs under this number, and 
>> don't see
>> that number in either of the 24xx errata docs either.   
>> Please clarify.
>
> Even I tried to find this info from errata docs prior to migrating
> all errata's to generic errata handling. This code was exising earlier,
> hence I retained it "as is", no documentation exists for this errata.
>

Hmm, OK.  

According to the code, it seems to affect every IP execpt 1510, yet it's
not documented in any of the errata docs.  

I wonder what happens if it is removed?

Kevin

  reply	other threads:[~2010-11-10 16:26 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 13:25 [PATCH v3 00/13] OMAP: DMA: hwmod and DMA as platform device G, Manjunath Kondaiah
2010-10-26 13:25 ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 14:48   ` Nishanth Menon
2010-10-26 14:48     ` Nishanth Menon
2010-10-27  3:54     ` G, Manjunath Kondaiah
2010-10-27  3:54       ` G, Manjunath Kondaiah
2010-10-27 14:26       ` Menon, Nishanth
2010-10-27 14:26         ` Menon, Nishanth
2010-10-29  8:15         ` G, Manjunath Kondaiah
2010-10-29  8:15           ` G, Manjunath Kondaiah
2010-11-09 21:37   ` Kevin Hilman
2010-11-09 21:37     ` Kevin Hilman
2010-11-10 14:01     ` G, Manjunath Kondaiah
2010-11-10 14:01       ` G, Manjunath Kondaiah
2010-11-10 16:03       ` Kevin Hilman
2010-11-10 16:03         ` Kevin Hilman
2010-11-10 17:16         ` G, Manjunath Kondaiah
2010-11-10 17:16           ` G, Manjunath Kondaiah
2010-11-10 17:35           ` Kevin Hilman
2010-11-10 17:35             ` Kevin Hilman
2010-10-26 13:25 ` [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 22:12   ` Kevin Hilman
2010-11-09 22:12     ` Kevin Hilman
2010-11-10 14:02     ` G, Manjunath Kondaiah
2010-11-10 14:02       ` G, Manjunath Kondaiah
2010-11-10 16:26       ` Kevin Hilman [this message]
2010-11-10 16:26         ` Kevin Hilman
2010-11-10 17:39         ` G, Manjunath Kondaiah
2010-11-10 17:39           ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 03/13] OMAP: DMA: Introduce DMA device attributes G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 21:46   ` Kevin Hilman
2010-11-09 21:46     ` Kevin Hilman
2010-10-26 13:25 ` [PATCH v3 04/13] OMAP2420: DMA: hwmod: add system DMA G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 23:13   ` Kevin Hilman
2010-11-09 23:13     ` Kevin Hilman
2010-11-11 23:04     ` Kevin Hilman
2010-11-11 23:04       ` Kevin Hilman
2010-10-26 13:25 ` [PATCH v3 05/13] OMAP2430: " G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 06/13] OMAP3: " G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-03 12:59   ` G, Manjunath Kondaiah
2010-11-03 12:59     ` G, Manjunath Kondaiah
2010-11-04  4:29     ` Cousson, Benoit
2010-11-04  4:29       ` Cousson, Benoit
2010-11-04  7:01       ` G, Manjunath Kondaiah
2010-11-04  7:01         ` G, Manjunath Kondaiah
2010-11-04 12:30         ` Cousson, Benoit
2010-11-04 12:30           ` Cousson, Benoit
2010-11-04 15:48           ` Kevin Hilman
2010-11-04 15:48             ` Kevin Hilman
2010-10-26 13:25 ` [PATCH v3 07/13] OMAP4: " G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 08/13] OMAP1: DMA: Introduce DMA driver as platform device G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 22:23   ` Kevin Hilman
2010-11-09 22:23     ` Kevin Hilman
2010-11-10 14:02     ` G, Manjunath Kondaiah
2010-11-10 14:02       ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 09/13] OMAP2+: DMA: hwmod: Device registration G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 10/13] OMAP: DMA: Convert DMA library into DMA platform Driver G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 22:26   ` Kevin Hilman
2010-11-09 22:26     ` Kevin Hilman
2010-11-10 14:02     ` G, Manjunath Kondaiah
2010-11-10 14:02       ` G, Manjunath Kondaiah
2010-11-10 16:24       ` Kevin Hilman
2010-11-10 16:24         ` Kevin Hilman
2010-11-10 17:23         ` G, Manjunath Kondaiah
2010-11-10 17:23           ` G, Manjunath Kondaiah
2010-11-10 17:56           ` Kevin Hilman
2010-11-10 17:56             ` Kevin Hilman
2010-11-09 23:29   ` Kevin Hilman
2010-11-09 23:29     ` Kevin Hilman
2010-11-10 14:02     ` G, Manjunath Kondaiah
2010-11-10 14:02       ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 11/13] OMAP: DMA: Use DMA device attributes G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 12/13] OMAP2+: DMA: descriptor autoloading feature G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-10-26 13:25 ` [PATCH v3 13/13] OMAP: PM: DMA: Enable runtime pm G, Manjunath Kondaiah
2010-10-26 13:25   ` G, Manjunath Kondaiah
2010-11-09 22:48   ` Kevin Hilman
2010-11-09 22:48     ` Kevin Hilman
2010-11-10 14:02     ` G, Manjunath Kondaiah
2010-11-10 14:02       ` G, Manjunath Kondaiah
2010-11-10 16:14       ` Kevin Hilman
2010-11-10 16:14         ` Kevin Hilman
2010-10-27  4:57 ` [PATCH v3 00/13] OMAP: DMA: hwmod and DMA as platform device G, Manjunath Kondaiah
2010-10-27  4:57   ` G, Manjunath Kondaiah
2010-11-09 23:11 ` Kevin Hilman
2010-11-09 23:11   ` Kevin Hilman
2010-11-10 14:02   ` G, Manjunath Kondaiah
2010-11-10 14:02     ` G, Manjunath Kondaiah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbfpcfh6.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=peter.ujfalusi@nokia.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.