All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: jes.sorensen@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed
Date: Wed, 10 Nov 2010 09:09:09 -0700	[thread overview]
Message-ID: <1289405349.14321.93.camel@x201> (raw)
In-Reply-To: <AANLkTinxVEms8AJ3TOxzxSqPcfkMehKaazjxOcX2O+Aa@mail.gmail.com>

On Sun, 2010-11-07 at 14:59 +0000, Blue Swirl wrote:
> On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson
> <alex.williamson@redhat.com> wrote:
> > We can't let the compiler define the alignment for qemu_cfg data.
> 
> Actually, whole e820_table implementation seems to be buggy. The
> structure may not be passed directly to fw_cfg interface without
> endianness conversions, otherwise the emulation will not work on big
> endian host.

I sent a patch for this a couple days ago:

http://lists.nongnu.org/archive/html/qemu-devel/2010-11/msg00481.html

I think that resolves your concern.  Thanks,

Alex

  reply	other threads:[~2010-11-10 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05 21:40 [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed Alex Williamson
2010-11-07 14:59 ` Blue Swirl
2010-11-10 16:09   ` Alex Williamson [this message]
2010-11-16 22:24 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289405349.14321.93.camel@x201 \
    --to=alex.williamson@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jes.sorensen@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.