From: Anthony Liguori <anthony@codemonkey.ws>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: jes.sorensen@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed
Date: Tue, 16 Nov 2010 16:24:50 -0600 [thread overview]
Message-ID: <4CE304B2.20407@codemonkey.ws> (raw)
In-Reply-To: <20101105214030.31799.12838.stgit@s20.home>
On 11/05/2010 04:40 PM, Alex Williamson wrote:
> We can't let the compiler define the alignment for qemu_cfg data.
>
> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> hw/pc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 69b13bf..0264e3d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -75,12 +75,12 @@ struct e820_entry {
> uint64_t address;
> uint64_t length;
> uint32_t type;
> -};
> +} __attribute((__packed__, __aligned__(4)));
>
> struct e820_table {
> uint32_t count;
> struct e820_entry entry[E820_NR_ENTRIES];
> -};
> +} __attribute((__packed__, __aligned__(4)));
>
> static struct e820_table e820_table;
>
>
>
>
>
prev parent reply other threads:[~2010-11-16 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 21:40 [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed Alex Williamson
2010-11-07 14:59 ` Blue Swirl
2010-11-10 16:09 ` Alex Williamson
2010-11-16 22:24 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE304B2.20407@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=alex.williamson@redhat.com \
--cc=jes.sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.