From: Joe Perches <joe@perches.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) to gfs2_print_dbg
Date: Wed, 10 Nov 2010 13:19:06 -0800 [thread overview]
Message-ID: <1289423946.15905.103.camel@Joe-Laptop> (raw)
In-Reply-To: <1289422527.2438.20.camel@dolmen>
Functions that use printf formatting, especially
those that use %pV, should have their uses of
printf format and arguments checked by the compiler.
Signed-off-by: Joe Perches <joe@perches.com>
---
No current uses report any error in an allyesconfig build.
fs/gfs2/glock.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h
index db1c26d..a12d117 100644
--- a/fs/gfs2/glock.h
+++ b/fs/gfs2/glock.h
@@ -212,6 +212,8 @@ int gfs2_glock_nq_num(struct gfs2_sbd *sdp,
int gfs2_glock_nq_m(unsigned int num_gh, struct gfs2_holder *ghs);
void gfs2_glock_dq_m(unsigned int num_gh, struct gfs2_holder *ghs);
void gfs2_glock_dq_uninit_m(unsigned int num_gh, struct gfs2_holder *ghs);
+
+__attribute__ ((format(printf, 2, 3)))
void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...);
/**
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf,2,3)) to gfs2_print_dbg
Date: Wed, 10 Nov 2010 13:19:06 -0800 [thread overview]
Message-ID: <1289423946.15905.103.camel@Joe-Laptop> (raw)
In-Reply-To: <1289422527.2438.20.camel@dolmen>
Functions that use printf formatting, especially
those that use %pV, should have their uses of
printf format and arguments checked by the compiler.
Signed-off-by: Joe Perches <joe@perches.com>
---
No current uses report any error in an allyesconfig build.
fs/gfs2/glock.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h
index db1c26d..a12d117 100644
--- a/fs/gfs2/glock.h
+++ b/fs/gfs2/glock.h
@@ -212,6 +212,8 @@ int gfs2_glock_nq_num(struct gfs2_sbd *sdp,
int gfs2_glock_nq_m(unsigned int num_gh, struct gfs2_holder *ghs);
void gfs2_glock_dq_m(unsigned int num_gh, struct gfs2_holder *ghs);
void gfs2_glock_dq_uninit_m(unsigned int num_gh, struct gfs2_holder *ghs);
+
+__attribute__ ((format(printf, 2, 3)))
void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...);
/**
next prev parent reply other threads:[~2010-11-10 21:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 0:35 [Cluster-devel] [PATCH 0/9] treewide: convert vprintk uses to %pV Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 0:35 ` [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 2:16 ` Kristian Høgsberg
2010-11-10 2:31 ` Joe Perches
2010-11-10 2:31 ` Joe Perches
2010-11-10 0:35 ` [PATCH 2/9] drivers/isdn/mISDN: " Joe Perches
2010-11-16 18:23 ` David Miller
2010-11-10 0:35 ` [PATCH 3/9] drivers/net/wireless/ath/debug.c: " Joe Perches
2010-11-10 0:35 ` [PATCH 4/9] drivers/net/wireless/b43/main.c: " Joe Perches
2010-11-10 0:35 ` [PATCH 5/9] drivers/net/wireless/b43legacy/main.c: " Joe Perches
2010-11-10 0:35 ` [Cluster-devel] [PATCH 6/9] fs/gfs2/glock.c: " Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 20:55 ` [Cluster-devel] " Steven Whitehouse
2010-11-10 20:55 ` Steven Whitehouse
2010-11-10 21:19 ` Joe Perches [this message]
2010-11-10 21:19 ` [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf,2,3)) to gfs2_print_dbg Joe Perches
2010-11-10 21:35 ` [Cluster-devel] [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) " Steven Whitehouse
2010-11-10 21:35 ` [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf,2,3)) " Steven Whitehouse
2010-11-10 0:35 ` [PATCH 8/9] fs/quota/dquot.c: Use printf extension %pV Joe Perches
2010-11-10 1:01 ` Jan Kara
2010-11-10 0:35 ` [PATCH 9/9] net/sunrpc/svc.c: " Joe Perches
[not found] ` <cover.1289348757.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-10 0:35 ` [PATCH 7/9] fs/nilfs2/super.c: " Joe Perches
2010-11-10 0:35 ` Joe Perches
[not found] ` <1addeb606bca88e09fb46b93be10c3a58e759348.1289348757.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-11 2:38 ` Ryusuke Konishi
2010-11-11 2:38 ` Ryusuke Konishi
2010-11-10 22:48 ` [PATCH 0/9] treewide: convert vprintk uses to %pV Luis R. Rodriguez
2010-11-10 22:48 ` Luis R. Rodriguez
2010-11-10 22:48 ` Luis R. Rodriguez
2010-11-10 23:01 ` [Cluster-devel] " Joe Perches
2010-11-10 23:01 ` Joe Perches
2010-11-10 23:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289423946.15905.103.camel@Joe-Laptop \
--to=joe@perches.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.