From: Joe Perches <joe@perches.com>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV
Date: Tue, 09 Nov 2010 18:31:03 -0800 [thread overview]
Message-ID: <1289356263.28590.85.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTi=Nu=rncb8+BzEGtphEj452xwVTPPM+EbCz0Fm1@mail.gmail.com>
On Tue, 2010-11-09 at 21:16 -0500, Kristian Høgsberg wrote:
> On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches <joe@perches.com> wrote:
> > Using %pV reduces the number of printk calls and
> > eliminates any possible message interleaving from
> > other printk calls.
> Wouldn't it be easier and more convenient to just make the %pV format
> specifier just expect a format string and the va_arg list? Like this
> printk(KERN_DEBUG "%pV", format, &args);
> I mean, the %pV is kernel specific and we can just change how it works.
No it wouldn't.
gcc would now warn about a mismatch between format and arguments.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: "Kristian Høgsberg" <krh@bitplanet.net>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV
Date: Tue, 09 Nov 2010 18:31:03 -0800 [thread overview]
Message-ID: <1289356263.28590.85.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTi=Nu=rncb8+BzEGtphEj452xwVTPPM+EbCz0Fm1@mail.gmail.com>
On Tue, 2010-11-09 at 21:16 -0500, Kristian Høgsberg wrote:
> On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches <joe@perches.com> wrote:
> > Using %pV reduces the number of printk calls and
> > eliminates any possible message interleaving from
> > other printk calls.
> Wouldn't it be easier and more convenient to just make the %pV format
> specifier just expect a format string and the va_arg list? Like this
> printk(KERN_DEBUG "%pV", format, &args);
> I mean, the %pV is kernel specific and we can just change how it works.
No it wouldn't.
gcc would now warn about a mismatch between format and arguments.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2010-11-10 2:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 0:35 [Cluster-devel] [PATCH 0/9] treewide: convert vprintk uses to %pV Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 0:35 ` [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 2:16 ` Kristian Høgsberg
2010-11-10 2:31 ` Joe Perches [this message]
2010-11-10 2:31 ` Joe Perches
2010-11-10 0:35 ` [PATCH 2/9] drivers/isdn/mISDN: " Joe Perches
2010-11-16 18:23 ` David Miller
2010-11-10 0:35 ` [PATCH 3/9] drivers/net/wireless/ath/debug.c: " Joe Perches
2010-11-10 0:35 ` [PATCH 4/9] drivers/net/wireless/b43/main.c: " Joe Perches
2010-11-10 0:35 ` [PATCH 5/9] drivers/net/wireless/b43legacy/main.c: " Joe Perches
2010-11-10 0:35 ` [Cluster-devel] [PATCH 6/9] fs/gfs2/glock.c: " Joe Perches
2010-11-10 0:35 ` Joe Perches
2010-11-10 20:55 ` [Cluster-devel] " Steven Whitehouse
2010-11-10 20:55 ` Steven Whitehouse
2010-11-10 21:19 ` [Cluster-devel] [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) to gfs2_print_dbg Joe Perches
2010-11-10 21:19 ` [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf,2,3)) " Joe Perches
2010-11-10 21:35 ` [Cluster-devel] [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf, 2, 3)) " Steven Whitehouse
2010-11-10 21:35 ` [PATCH] fs/gfs2/glock.h: Add __attribute__((format(printf,2,3)) " Steven Whitehouse
[not found] ` <cover.1289348757.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-10 0:35 ` [PATCH 7/9] fs/nilfs2/super.c: Use printf extension %pV Joe Perches
2010-11-10 0:35 ` Joe Perches
[not found] ` <1addeb606bca88e09fb46b93be10c3a58e759348.1289348757.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2010-11-11 2:38 ` Ryusuke Konishi
2010-11-11 2:38 ` Ryusuke Konishi
2010-11-10 22:48 ` [PATCH 0/9] treewide: convert vprintk uses to %pV Luis R. Rodriguez
2010-11-10 22:48 ` Luis R. Rodriguez
2010-11-10 22:48 ` Luis R. Rodriguez
2010-11-10 23:01 ` [Cluster-devel] " Joe Perches
2010-11-10 23:01 ` Joe Perches
2010-11-10 23:01 ` Joe Perches
2010-11-10 0:35 ` [PATCH 8/9] fs/quota/dquot.c: Use printf extension %pV Joe Perches
2010-11-10 1:01 ` Jan Kara
2010-11-10 0:35 ` [PATCH 9/9] net/sunrpc/svc.c: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289356263.28590.85.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krh@bitplanet.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.