From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Urs Thuermann <urs.thuermann@volkswagen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
James Morris <jmorris@namei.org>,
Remi Denis-Courmont <remi.denis-courmont@nokia.com>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
Sridhar Samudrala <sri@us.ibm.com>,
Vlad Yasevich <vladislav.yasevich@hp.com>,
Tejun Heo <tj@kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>, Joe Perches <joe@perches.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Jamal Hadi Salim <hadi@mojatatu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Jiri Pirko <jpirko@redhat.com>,
Johannes Berg <johannes.berg@intel.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Pavel
Subject: Re: [PATCH 2/10] Fix leaking of kernel heap addresses in net/
Date: Fri, 12 Nov 2010 15:11:51 +0000 [thread overview]
Message-ID: <1289574711.3090.285.camel@Dan> (raw)
In-Reply-To: <1289574562.2247.1.camel@achroite.uk.solarflarecom.com>
> On Thu, 2010-11-11 at 20:06 -0500, Dan Rosenberg wrote:
> > diff --git a/net/can/bcm.c b/net/can/bcm.c
> > index 08ffe9e..5960ad7 100644
> > --- a/net/can/bcm.c
> > +++ b/net/can/bcm.c
> [...]
> > + seq_printf(m, ">>> socket %lu", sock_i_ino(sk));
>
> Why decimal here...
>
> [...]
> > + /* unique socket inode as filename */
> > + sprintf(bo->procname, "%lx", sock_i_ino(sk));
>
> ...and hexadecimal here?
>
> Ben.
>
You're right, it should be consistent. I avoided decimal in the /proc
filename because it may be too long - the next version will do the same
for the seq_print output.
-Dan
WARNING: multiple messages have this Message-ID (diff)
From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Urs Thuermann <urs.thuermann@volkswagen.de>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
James Morris <jmorris@namei.org>,
Remi Denis-Courmont <remi.denis-courmont@nokia.com>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
Sridhar Samudrala <sri@us.ibm.com>,
Vlad Yasevich <vladislav.yasevich@hp.com>,
Tejun Heo <tj@kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>, Joe Perches <joe@perches.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Jamal Hadi Salim <hadi@mojatatu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Jiri Pirko <jpirko@redhat.com>,
Johannes Berg <johannes.berg@intel.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Pavel Eme
Subject: Re: [PATCH 2/10] Fix leaking of kernel heap addresses in net/
Date: Fri, 12 Nov 2010 10:11:51 -0500 [thread overview]
Message-ID: <1289574711.3090.285.camel@Dan> (raw)
In-Reply-To: <1289574562.2247.1.camel@achroite.uk.solarflarecom.com>
> On Thu, 2010-11-11 at 20:06 -0500, Dan Rosenberg wrote:
> > diff --git a/net/can/bcm.c b/net/can/bcm.c
> > index 08ffe9e..5960ad7 100644
> > --- a/net/can/bcm.c
> > +++ b/net/can/bcm.c
> [...]
> > + seq_printf(m, ">>> socket %lu", sock_i_ino(sk));
>
> Why decimal here...
>
> [...]
> > + /* unique socket inode as filename */
> > + sprintf(bo->procname, "%lx", sock_i_ino(sk));
>
> ...and hexadecimal here?
>
> Ben.
>
You're right, it should be consistent. I avoided decimal in the /proc
filename because it may be too long - the next version will do the same
for the seq_print output.
-Dan
next prev parent reply other threads:[~2010-11-12 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 1:06 [PATCH 2/10] Fix leaking of kernel heap addresses in net/ Dan Rosenberg
2010-11-12 1:06 ` Dan Rosenberg
2010-11-12 1:17 ` Stephen Hemminger
2010-11-12 1:22 ` Dan Rosenberg
2010-11-12 15:09 ` Ben Hutchings
2010-11-12 15:09 ` Ben Hutchings
2010-11-12 15:11 ` Dan Rosenberg [this message]
2010-11-12 15:11 ` Dan Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289574711.3090.285.camel@Dan \
--to=drosenberg@vsecurity.com \
--cc=adobriyan@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=daniel.lezcano@free.fr \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=hadi@mojatatu.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=lizf@cn.fujitsu.com \
--cc=pekkas@netcore.fi \
--cc=remi.denis-courmont@nokia.com \
--cc=shemminger@vyatta.com \
--cc=socketcan@hartkopp.net \
--cc=sri@us.ibm.com \
--cc=tj@kernel.org \
--cc=urs.thuermann@volkswagen.de \
--cc=vladislav.yasevich@hp.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.