All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steven J. Magnani" <steve@digidescorp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Greg Ungerer <gerg@snapgear.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH][RESEND] nommu: yield CPU periodically while disposing large VM
Date: Tue, 16 Nov 2010 07:03:57 -0600	[thread overview]
Message-ID: <1289912637.3449.3.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <20101115204703.fc774a17.akpm@linux-foundation.org>

On Mon, 2010-11-15 at 20:47 -0800, Andrew Morton wrote:
> On Mon, 15 Nov 2010 08:29:11 -0600 "Steven J. Magnani" <steve@digidescorp.com> wrote:
> 
> > As efficient as schedule() may be, it still scares me to call it on
> > reclaim of every block of memory allocated by a terminating process,
> > particularly on the relatively slow processors that inhabit NOMMU land.
> 
> This is cond_resched(), not schedule()!  cond_resched() is just a few
> instructions, except for the super-rare case where it calls schedule().

The light comes on..._cond_resched() is overloaded. I was looking at the
static version, which calls schedule(). The extern version is much more
lightweight.

I'll respin the patch.

Thanks,
------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>




WARNING: multiple messages have this Message-ID (diff)
From: "Steven J. Magnani" <steve@digidescorp.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Greg Ungerer <gerg@snapgear.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH][RESEND] nommu: yield CPU periodically while disposing large VM
Date: Tue, 16 Nov 2010 07:03:57 -0600	[thread overview]
Message-ID: <1289912637.3449.3.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <20101115204703.fc774a17.akpm@linux-foundation.org>

On Mon, 2010-11-15 at 20:47 -0800, Andrew Morton wrote:
> On Mon, 15 Nov 2010 08:29:11 -0600 "Steven J. Magnani" <steve@digidescorp.com> wrote:
> 
> > As efficient as schedule() may be, it still scares me to call it on
> > reclaim of every block of memory allocated by a terminating process,
> > particularly on the relatively slow processors that inhabit NOMMU land.
> 
> This is cond_resched(), not schedule()!  cond_resched() is just a few
> instructions, except for the super-rare case where it calls schedule().

The light comes on..._cond_resched() is overloaded. I was looking at the
static version, which calls schedule(). The extern version is much more
lightweight.

I'll respin the patch.

Thanks,
------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-11-16 13:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 20:33 [PATCH][RESEND] nommu: yield CPU periodically while disposing large VM Steven J. Magnani
2010-11-11 20:33 ` Steven J. Magnani
2010-11-12  2:40 ` Andrew Morton
2010-11-12  2:40   ` Andrew Morton
2010-11-15 14:29   ` Steven J. Magnani
2010-11-15 14:29     ` Steven J. Magnani
2010-11-16  4:47     ` Andrew Morton
2010-11-16  4:47       ` Andrew Morton
2010-11-16 13:03       ` Steven J. Magnani [this message]
2010-11-16 13:03         ` Steven J. Magnani
2010-11-14  5:07 ` KOSAKI Motohiro
2010-11-14  5:07   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289912637.3449.3.camel@iscandar.digidescorp.com \
    --to=steve@digidescorp.com \
    --cc=akpm@linux-foundation.org \
    --cc=gerg@snapgear.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.