From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Rupjyoti Sarmah <rsarmah@amcc.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
rsarmah@apm.com
Subject: Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board
Date: Wed, 24 Nov 2010 08:10:21 +1100 [thread overview]
Message-ID: <1290546621.32570.85.camel@pasglop> (raw)
In-Reply-To: <201011231421.02377.sr@denx.de>
> > + setbits8(&bcsr[7], BCSR_USB_EN);
> > + udelay(100000);
> > +
> > + clrbits8(&bcsr[7], BCSR_USB_EN);
> > + udelay(100000);
>
> Thats a total bootup delay of 200ms. Is this really needed?
In addition, so large delays should use msleep() if possible (depends
how early we are here).
Cheers,
Ben,
> And I suggest to add a few comments to the code explaining why exactly you are
> setting/clearing the bits in the BCSR and the GPIO registers.
Seconded,
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@lists.ozlabs.org, linuxppc-dev@ozlabs.org,
Rupjyoti Sarmah <rsarmah@amcc.com>,
rsarmah@apm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board
Date: Wed, 24 Nov 2010 08:10:21 +1100 [thread overview]
Message-ID: <1290546621.32570.85.camel@pasglop> (raw)
In-Reply-To: <201011231421.02377.sr@denx.de>
> > + setbits8(&bcsr[7], BCSR_USB_EN);
> > + udelay(100000);
> > +
> > + clrbits8(&bcsr[7], BCSR_USB_EN);
> > + udelay(100000);
>
> Thats a total bootup delay of 200ms. Is this really needed?
In addition, so large delays should use msleep() if possible (depends
how early we are here).
Cheers,
Ben,
> And I suggest to add a few comments to the code explaining why exactly you are
> setting/clearing the bits in the BCSR and the GPIO registers.
Seconded,
Cheers,
Ben.
next prev parent reply other threads:[~2010-11-23 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 12:56 [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board Rupjyoti Sarmah
2010-11-23 13:21 ` Stefan Roese
2010-11-23 13:21 ` Stefan Roese
2010-11-23 21:10 ` Benjamin Herrenschmidt [this message]
2010-11-23 21:10 ` Benjamin Herrenschmidt
2010-11-24 4:55 ` Rupjyoti Sarmah
2010-11-24 5:30 ` Stefan Roese
2010-11-24 7:32 ` Benjamin Herrenschmidt
2010-11-24 7:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290546621.32570.85.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=rsarmah@apm.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.