From: Joe Perches <joe@perches.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Tue, 30 Nov 2010 12:19:35 -0800 [thread overview]
Message-ID: <1291148375.18026.342.camel@Joe-Laptop> (raw)
In-Reply-To: <4CF464D6.2020507@openwrt.org>
On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote:
> On 2010-11-30 2:39 AM, Joe Perches wrote:
> > I gauge my willingness to spend time on subsystems on
> > the maintainers willingness to merge things that improve
> > readability and correctness.
> I'm not trying to discourage you from spending time on improving this
> code, just doubting the usefulness of such simple function renames.
Poor function naming is just that.
It reduces readability and the uses are counter expectation.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: peter@stuge.se, ath9k-devel@lists.ath9k.org,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Tue, 30 Nov 2010 12:19:35 -0800 [thread overview]
Message-ID: <1291148375.18026.342.camel@Joe-Laptop> (raw)
In-Reply-To: <4CF464D6.2020507@openwrt.org>
On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote:
> On 2010-11-30 2:39 AM, Joe Perches wrote:
> > I gauge my willingness to spend time on subsystems on
> > the maintainers willingness to merge things that improve
> > readability and correctness.
> I'm not trying to discourage you from spending time on improving this
> code, just doubting the usefulness of such simple function renames.
Poor function naming is just that.
It reduces readability and the uses are counter expectation.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: peter@stuge.se, ath9k-devel@venema.h4ckr.net,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Tue, 30 Nov 2010 12:19:35 -0800 [thread overview]
Message-ID: <1291148375.18026.342.camel@Joe-Laptop> (raw)
In-Reply-To: <4CF464D6.2020507@openwrt.org>
On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote:
> On 2010-11-30 2:39 AM, Joe Perches wrote:
> > I gauge my willingness to spend time on subsystems on
> > the maintainers willingness to merge things that improve
> > readability and correctness.
> I'm not trying to discourage you from spending time on improving this
> code, just doubting the usefulness of such simple function renames.
Poor function naming is just that.
It reduces readability and the uses are counter expectation.
next prev parent reply other threads:[~2010-11-30 20:19 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 23:53 [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-29 2:17 ` [ath9k-devel] " Luis R. Rodriguez
2010-11-29 2:17 ` Luis R. Rodriguez
2010-11-29 2:17 ` Luis R. Rodriguez
2010-11-29 6:07 ` [ath9k-devel] " Peter Stuge
2010-11-29 6:07 ` Peter Stuge
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-30 1:39 ` Joe Perches
2010-11-30 1:39 ` Joe Perches
2010-11-30 1:39 ` Joe Perches
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 20:19 ` Joe Perches [this message]
2010-11-30 20:19 ` Joe Perches
2010-11-30 20:19 ` Joe Perches
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:44 ` [ath9k-devel] [PATCH] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-01 17:44 ` Joe Perches
2010-12-01 17:44 ` Joe Perches
2010-12-01 18:05 ` [ath9k-devel] [PATCH V2] " Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 19:08 ` [ath9k-devel] [PATCH] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 17:37 ` [ath9k-devel] [PATCH wireless-next] MAINTAINERS: Add ATH GENERIC UTILITIES Joe Perches
2010-12-01 17:37 ` Joe Perches
2010-12-01 17:37 ` Joe Perches
2010-12-01 19:46 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 20:16 ` [ath9k-devel] " Joe Perches
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:18 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:41 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 20:41 ` Luis R. Rodriguez
2010-12-01 20:41 ` Luis R. Rodriguez
2010-12-02 0:48 ` Joe Perches
2010-12-02 0:48 ` Joe Perches
2010-12-02 0:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291148375.18026.342.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.