From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Wed, 01 Dec 2010 15:37:45 +0100 [thread overview]
Message-ID: <4CF65DB9.3050007@openwrt.org> (raw)
In-Reply-To: <1291213675.1845.12.camel@Joe-Laptop>
On 2010-12-01 3:27 PM, Joe Perches wrote:
> On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote:
>> On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches <joe@perches.com> wrote:
>> > Poor function naming is just that.
>> > It reduces readability and the uses are counter expectation.
>> The name is perfect, we use it to print anything, even non-debugging stuff.
>
> 'fraid not.
>
> ath/debug.h
>
> #ifdef CONFIG_ATH_DEBUG
> void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> __attribute__ ((format (printf, 3, 4)));
> #else
> static inline void __attribute__ ((format (printf, 3, 4)))
> ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> {
> }
> #endif /* CONFIG_ATH_DEBUG */
Now we're getting closer to something worth fixing. IMHO we should
change the code so that ath_print(common, ATH_DBG_FATAL, ...) prints
something even with CONFIG_ATH_DEBUG unset. To get this done, some
renaming would make sense here.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Joe Perches <joe@perches.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@lists.ath9k.org, peter@stuge.se,
linux-kernel@vger.kernel.org
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Wed, 01 Dec 2010 15:37:45 +0100 [thread overview]
Message-ID: <4CF65DB9.3050007@openwrt.org> (raw)
In-Reply-To: <1291213675.1845.12.camel@Joe-Laptop>
On 2010-12-01 3:27 PM, Joe Perches wrote:
> On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote:
>> On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches <joe@perches.com> wrote:
>> > Poor function naming is just that.
>> > It reduces readability and the uses are counter expectation.
>> The name is perfect, we use it to print anything, even non-debugging stuff.
>
> 'fraid not.
>
> ath/debug.h
>
> #ifdef CONFIG_ATH_DEBUG
> void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> __attribute__ ((format (printf, 3, 4)));
> #else
> static inline void __attribute__ ((format (printf, 3, 4)))
> ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> {
> }
> #endif /* CONFIG_ATH_DEBUG */
Now we're getting closer to something worth fixing. IMHO we should
change the code so that ath_print(common, ATH_DBG_FATAL, ...) prints
something even with CONFIG_ATH_DEBUG unset. To get this done, some
renaming would make sense here.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Joe Perches <joe@perches.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@venema.h4ckr.net, peter@stuge.se,
linux-kernel@vger.kernel.org
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Wed, 01 Dec 2010 15:37:45 +0100 [thread overview]
Message-ID: <4CF65DB9.3050007@openwrt.org> (raw)
In-Reply-To: <1291213675.1845.12.camel@Joe-Laptop>
On 2010-12-01 3:27 PM, Joe Perches wrote:
> On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote:
>> On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches <joe@perches.com> wrote:
>> > Poor function naming is just that.
>> > It reduces readability and the uses are counter expectation.
>> The name is perfect, we use it to print anything, even non-debugging stuff.
>
> 'fraid not.
>
> ath/debug.h
>
> #ifdef CONFIG_ATH_DEBUG
> void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> __attribute__ ((format (printf, 3, 4)));
> #else
> static inline void __attribute__ ((format (printf, 3, 4)))
> ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
> {
> }
> #endif /* CONFIG_ATH_DEBUG */
Now we're getting closer to something worth fixing. IMHO we should
change the code so that ath_print(common, ATH_DBG_FATAL, ...) prints
something even with CONFIG_ATH_DEBUG unset. To get this done, some
renaming would make sense here.
- Felix
next prev parent reply other threads:[~2010-12-01 14:37 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 23:53 [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-28 23:53 ` Joe Perches
2010-11-29 2:17 ` [ath9k-devel] " Luis R. Rodriguez
2010-11-29 2:17 ` Luis R. Rodriguez
2010-11-29 2:17 ` Luis R. Rodriguez
2010-11-29 6:07 ` [ath9k-devel] " Peter Stuge
2010-11-29 6:07 ` Peter Stuge
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:41 ` Felix Fietkau
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-30 1:39 ` Joe Perches
2010-11-30 1:39 ` Joe Perches
2010-11-30 1:39 ` Joe Perches
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 20:19 ` Joe Perches
2010-11-30 20:19 ` Joe Perches
2010-11-30 20:19 ` Joe Perches
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:27 ` Joe Perches
2010-12-01 14:37 ` Felix Fietkau [this message]
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:44 ` [ath9k-devel] [PATCH] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-01 17:44 ` Joe Perches
2010-12-01 17:44 ` Joe Perches
2010-12-01 18:05 ` [ath9k-devel] [PATCH V2] " Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 18:05 ` Joe Perches
2010-12-01 19:08 ` [ath9k-devel] [PATCH] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 19:08 ` Joe Perches
2010-12-01 17:37 ` [ath9k-devel] [PATCH wireless-next] MAINTAINERS: Add ATH GENERIC UTILITIES Joe Perches
2010-12-01 17:37 ` Joe Perches
2010-12-01 17:37 ` Joe Perches
2010-12-01 19:46 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 20:16 ` [ath9k-devel] " Joe Perches
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:18 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:41 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-01 20:41 ` Luis R. Rodriguez
2010-12-01 20:41 ` Luis R. Rodriguez
2010-12-02 0:48 ` Joe Perches
2010-12-02 0:48 ` Joe Perches
2010-12-02 0:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF65DB9.3050007@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.