All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events
Date: Wed, 01 Dec 2010 19:37:04 +0100	[thread overview]
Message-ID: <1291228624.32004.1852.camel@laptop> (raw)
In-Reply-To: <20101201182910.GC3438@nowhere>

On Wed, 2010-12-01 at 19:29 +0100, Frederic Weisbecker wrote:
> > +static int perf_event_add_tp(struct perf_event *event, int tp_id)
> > +{
> > +     if (event->attr.type != PERF_TYPE_TRACEPOINT &&
> 
> Should it be || instead?
> 
> > +         event->attr.config != ~0ULL)
> > +             return -EINVAL;
> > +
> > +     return __perf_event_add_tp(event, tp_id);
> > +} 

Probably,.. yeah.

  reply	other threads:[~2010-12-01 18:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01  1:00 [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events Corey Ashford
2010-12-01 11:46 ` Peter Zijlstra
2010-12-01 12:04   ` Peter Zijlstra
2010-12-01 18:02     ` Frederic Weisbecker
2010-12-01 18:52       ` Peter Zijlstra
2010-12-02 17:56         ` Frederic Weisbecker
2010-12-01 18:29     ` Frederic Weisbecker
2010-12-01 18:37       ` Peter Zijlstra [this message]
2010-12-01 19:22   ` Corey Ashford
2010-12-01 19:30     ` Peter Zijlstra
2010-12-02  8:58 ` Corey Ashford
2010-12-09 19:56   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291228624.32004.1852.camel@laptop \
    --to=peterz@infradead.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.