All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Ashford <cjashfor@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events
Date: Wed, 01 Dec 2010 11:22:12 -0800	[thread overview]
Message-ID: <4CF6A064.9030807@linux.vnet.ibm.com> (raw)
In-Reply-To: <1291203990.4023.16.camel@twins>

Thanks for your reply, Peter.

On 12/01/2010 03:46 AM, Peter Zijlstra wrote:
> On Tue, 2010-11-30 at 17:00 -0800, Corey Ashford wrote:
>> Hi,
>>
>> I'm not sure that what I'm seeing is a bug, or was something intentional.
>>
>> If I place multiple tracepoint events into a group and measure counts of
>> these events on a process, I get no counts for the tracepoint events
>> other than the group leader.
>>
>> Is this expected behavior?
>>
>> It's not clear to me why this should be the case; grouping shouldn't
>> have any ill effects on tracepoint events, from my understanding.
>>
>> I noticed this because my private version of the perf tool has the event
>> group patch https://lkml.org/lkml/2010/11/24/584 as well as the patch
>> which fixes the parsing of multiple tracepoint events in the same -e
>> switch: https://lkml.org/lkml/2010/11/30/460
>>
>> When I dig into the code a bit, I find that each event opens
>> successfully, so that's not the problem.  If I disable the grouping,
>> then I get counts for all of the tracepoint events.
>
> Hrm,.. definitely not expected. I'll try and look into it, but I'm a bit
> over-committed atm.
>
> Also, I've started a rewrite of the whole tracepoint<->  perf
> interaction:
>
>    http://lkml.org/lkml/2010/11/23/147
>
> Could you see if that cures your problem?

I've had some trouble getting recent kernels to boot on my Power5 
machine, but I might be able to try it on my laptop.

>
> Another thing to test, does the same hold true for regular software
> events? tracepoints and software events share a lot of infrastructure.

I just tried "perf stat -e context-switches,faults ..." on both my 
laptop (running 2.6.35), and on my Power5 machine (running 2.6.33) and I 
get the same behavior when software events are grouped, e.g.:
% ./perf stat -e context-switches,faults ~/load 1000

  Performance counter stats for '/home/corey/load 1000':

                 240  context-switches
       <not counted>  page-faults

         2.382022393  seconds time elapsed

So I suppose that points to a common flaw in the tracepoint and software 
event logic.

With that in mind, would it still make sense to try out your tracepoint 
patch?

- Corey

  parent reply	other threads:[~2010-12-01 19:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01  1:00 [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events Corey Ashford
2010-12-01 11:46 ` Peter Zijlstra
2010-12-01 12:04   ` Peter Zijlstra
2010-12-01 18:02     ` Frederic Weisbecker
2010-12-01 18:52       ` Peter Zijlstra
2010-12-02 17:56         ` Frederic Weisbecker
2010-12-01 18:29     ` Frederic Weisbecker
2010-12-01 18:37       ` Peter Zijlstra
2010-12-01 19:22   ` Corey Ashford [this message]
2010-12-01 19:30     ` Peter Zijlstra
2010-12-02  8:58 ` Corey Ashford
2010-12-09 19:56   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF6A064.9030807@linux.vnet.ibm.com \
    --to=cjashfor@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.