All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Ashford <cjashfor@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events
Date: Thu, 02 Dec 2010 00:58:42 -0800	[thread overview]
Message-ID: <4CF75FC2.6080108@linux.vnet.ibm.com> (raw)
In-Reply-To: <4CF59E20.1040301@linux.vnet.ibm.com>

On 11/30/2010 05:00 PM, Corey Ashford wrote:
>
> Hi,
>
> I'm not sure that what I'm seeing is a bug, or was something intentional.
>
> If I place multiple tracepoint events into a group and measure counts of
> these events on a process, I get no counts for the tracepoint events
> other than the group leader.
>
> Is this expected behavior?
>
> It's not clear to me why this should be the case; grouping shouldn't
> have any ill effects on tracepoint events, from my understanding.
>
> I noticed this because my private version of the perf tool has the event
> group patch https://lkml.org/lkml/2010/11/24/584 as well as the patch
> which fixes the parsing of multiple tracepoint events in the same -e
> switch: https://lkml.org/lkml/2010/11/30/460
>
> When I dig into the code a bit, I find that each event opens
> successfully, so that's not the problem. If I disable the grouping, then
> I get counts for all of the tracepoint events.

False alarm.  I found a bug in my forwarded-ported version of the event 
grouping patch for perf stat.  I was setting the attr->disabled bit for 
all of the events instead of just the group leader, when forking off the 
command.

Software events, tracepoints, and hardware events all work when grouped 
now.  Sorry, I should have been more thorough in testing this on other 
types of events.  I had thought I had it working with hardware events, 
and it was, but only if I attached to an existing process, not when 
forking off a new command.  Anyway, if I had tested with hardware events 
in the same way I had tested tracepoints I would have seen the problem.

So the patch mentioned above, https://lkml.org/lkml/2010/11/24/584, has 
a bug, but since it didn't get committed, I suppose it's not a problem. 
  If anyone is still interested, I can post a v4 of that patch.

Sorry for the bother!

- Corey

  parent reply	other threads:[~2010-12-02  8:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01  1:00 [BUG(?)] perf_events: combining multiple tracepoint events into a group produces no counts on member events Corey Ashford
2010-12-01 11:46 ` Peter Zijlstra
2010-12-01 12:04   ` Peter Zijlstra
2010-12-01 18:02     ` Frederic Weisbecker
2010-12-01 18:52       ` Peter Zijlstra
2010-12-02 17:56         ` Frederic Weisbecker
2010-12-01 18:29     ` Frederic Weisbecker
2010-12-01 18:37       ` Peter Zijlstra
2010-12-01 19:22   ` Corey Ashford
2010-12-01 19:30     ` Peter Zijlstra
2010-12-02  8:58 ` Corey Ashford [this message]
2010-12-09 19:56   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF75FC2.6080108@linux.vnet.ibm.com \
    --to=cjashfor@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.