From: greearb at gmail.com <greearb@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start
Date: Mon, 6 Dec 2010 21:13:49 -0800 [thread overview]
Message-ID: <1291698829-22765-1-git-send-email-greearb@candelatech.com> (raw)
From: Ben Greear <greearb@candelatech.com>
It can be NULL according to docs, and logging showed it
to be NULL in practice.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 8b0b076... 5ddca08... M drivers/net/wireless/ath/ath9k/xmit.c
drivers/net/wireless/ath/ath9k/xmit.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 8b0b076..5ddca08 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1764,7 +1764,10 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
int frmlen = skb->len + FCS_LEN;
int q;
- txctl->an = (struct ath_node *)sta->drv_priv;
+ /* NOTE: sta can be NULL according to net/mac80211.h */
+ if (sta)
+ txctl->an = (struct ath_node *)sta->drv_priv;
+
if (info->control.hw_key)
frmlen += info->control.hw_key->icv_len;
--
1.7.2.3
WARNING: multiple messages have this Message-ID (diff)
From: greearb@gmail.com
To: linux-wireless@vger.kernel.org
Cc: ath9k-devel@venema.h4ckr.net, Ben Greear <greearb@candelatech.com>
Subject: [PATCH] ath9k: Check for NULL sta in ath_tx_start
Date: Mon, 6 Dec 2010 21:13:49 -0800 [thread overview]
Message-ID: <1291698829-22765-1-git-send-email-greearb@candelatech.com> (raw)
From: Ben Greear <greearb@candelatech.com>
It can be NULL according to docs, and logging showed it
to be NULL in practice.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 8b0b076... 5ddca08... M drivers/net/wireless/ath/ath9k/xmit.c
drivers/net/wireless/ath/ath9k/xmit.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 8b0b076..5ddca08 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1764,7 +1764,10 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
int frmlen = skb->len + FCS_LEN;
int q;
- txctl->an = (struct ath_node *)sta->drv_priv;
+ /* NOTE: sta can be NULL according to net/mac80211.h */
+ if (sta)
+ txctl->an = (struct ath_node *)sta->drv_priv;
+
if (info->control.hw_key)
frmlen += info->control.hw_key->icv_len;
--
1.7.2.3
next reply other threads:[~2010-12-07 5:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 5:13 greearb at gmail.com [this message]
2010-12-07 5:13 ` [PATCH] ath9k: Check for NULL sta in ath_tx_start greearb
2010-12-07 5:21 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-07 5:21 ` Luis R. Rodriguez
2010-12-07 5:36 ` [ath9k-devel] " Ben Greear
2010-12-07 5:36 ` Ben Greear
2010-12-07 7:42 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-07 7:42 ` Vasanthakumar Thiagarajan
2010-12-07 7:49 ` [ath9k-devel] " Ben Greear
2010-12-07 7:49 ` Ben Greear
2010-12-07 8:31 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-07 8:31 ` Vasanthakumar Thiagarajan
2010-12-07 17:13 ` [ath9k-devel] " Ben Greear
2010-12-07 17:13 ` Ben Greear
2010-12-08 5:17 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-08 5:17 ` Vasanthakumar Thiagarajan
2010-12-08 15:40 ` [ath9k-devel] " Ben Greear
2010-12-08 15:40 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291698829-22765-1-git-send-email-greearb@candelatech.com \
--to=greearb@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.