From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start
Date: Mon, 06 Dec 2010 21:36:24 -0800 [thread overview]
Message-ID: <4CFDC7D8.3080100@candelatech.com> (raw)
In-Reply-To: <AANLkTik20SkL0Y5gK_ysYpW46gvb73m4h3SDcGb+d_LA@mail.gmail.com>
On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote:
> On Mon, Dec 6, 2010 at 9:13 PM,<greearb@gmail.com> wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> It can be NULL according to docs, and logging showed it
>> to be NULL in practice.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>
> Does this fix an oops? If so can you explain and provide the trace and
> resubmit and cc stable in the commit log?
I think it fixes the TID corruption I posted about earlier. It seems
so obvious though, that I'm curious why no one else sees problems,
and why I didn't see more crashes in my setup.
(The paprd code appears to send with null STA, for instance, and my
printks showed lots of NULL stas in my 16-sta test setup, though I
don't think I'm using the paprd code path.)
I'll test some more and re-post tomorrow if all goes well.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: greearb@gmail.com, linux-wireless@vger.kernel.org,
ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: Check for NULL sta in ath_tx_start
Date: Mon, 06 Dec 2010 21:36:24 -0800 [thread overview]
Message-ID: <4CFDC7D8.3080100@candelatech.com> (raw)
In-Reply-To: <AANLkTik20SkL0Y5gK_ysYpW46gvb73m4h3SDcGb+d_LA@mail.gmail.com>
On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote:
> On Mon, Dec 6, 2010 at 9:13 PM,<greearb@gmail.com> wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> It can be NULL according to docs, and logging showed it
>> to be NULL in practice.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>
> Does this fix an oops? If so can you explain and provide the trace and
> resubmit and cc stable in the commit log?
I think it fixes the TID corruption I posted about earlier. It seems
so obvious though, that I'm curious why no one else sees problems,
and why I didn't see more crashes in my setup.
(The paprd code appears to send with null STA, for instance, and my
printks showed lots of NULL stas in my 16-sta test setup, though I
don't think I'm using the paprd code path.)
I'll test some more and re-post tomorrow if all goes well.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-12-07 5:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 5:13 [ath9k-devel] [PATCH] ath9k: Check for NULL sta in ath_tx_start greearb at gmail.com
2010-12-07 5:13 ` greearb
2010-12-07 5:21 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-07 5:21 ` Luis R. Rodriguez
2010-12-07 5:36 ` Ben Greear [this message]
2010-12-07 5:36 ` Ben Greear
2010-12-07 7:42 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-07 7:42 ` Vasanthakumar Thiagarajan
2010-12-07 7:49 ` [ath9k-devel] " Ben Greear
2010-12-07 7:49 ` Ben Greear
2010-12-07 8:31 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-07 8:31 ` Vasanthakumar Thiagarajan
2010-12-07 17:13 ` [ath9k-devel] " Ben Greear
2010-12-07 17:13 ` Ben Greear
2010-12-08 5:17 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-12-08 5:17 ` Vasanthakumar Thiagarajan
2010-12-08 15:40 ` [ath9k-devel] " Ben Greear
2010-12-08 15:40 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFDC7D8.3080100@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.