From: s.neumann@raumfeld.com (Sven Neumann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa3xx: fix PXA GPIO IRQ handling
Date: Tue, 18 Jan 2011 22:49:07 +0100 [thread overview]
Message-ID: <1295387347.20633.3.camel@bender> (raw)
In-Reply-To: <AANLkTi=gGDZHukdSuupg22Gb9te+Vk_rsu6-vREeQRVE@mail.gmail.com>
On Tue, 2011-01-18 at 08:15 -0800, Eric Miao wrote:
> On Tue, Jan 18, 2011 at 3:47 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> > On 01/18/2011 09:18 AM, Sven Neumann wrote:
> >> From: Lars-Peter Clausen <lars@metafoo.de>
> >>
> >> Set the "set_wake" field of the irq_chip struct before calling
> >> set_irq_chip() for all of the IRQs, so that the compat handler
> >> actually gets installed.
>
> Not really sure if this is necessary. Lennert has done the transition to
> irq_data to those _set_wake() functions as well, so it should be OK
> that compat handler doesn't get installed.
>
> Now I'm not against moving this above, just wondering if there were
> any consequences/errors coming out?
Well, our PXA300 device doesn't power up again when it should resume
from suspend. Fine with me if this has been fixed upstream, but I would
still like to get this patch into 2.6.37. I'll try to test upstream as
soon as Linus releases 2.6.38-rc1...
Sven
WARNING: multiple messages have this Message-ID (diff)
From: Sven Neumann <s.neumann@raumfeld.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Lennert Buijtenhek <buytenh@wantstofly.org>,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Daniel Mack <daniel@caiaq.de>
Subject: Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling
Date: Tue, 18 Jan 2011 22:49:07 +0100 [thread overview]
Message-ID: <1295387347.20633.3.camel@bender> (raw)
In-Reply-To: <AANLkTi=gGDZHukdSuupg22Gb9te+Vk_rsu6-vREeQRVE@mail.gmail.com>
On Tue, 2011-01-18 at 08:15 -0800, Eric Miao wrote:
> On Tue, Jan 18, 2011 at 3:47 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> > On 01/18/2011 09:18 AM, Sven Neumann wrote:
> >> From: Lars-Peter Clausen <lars@metafoo.de>
> >>
> >> Set the "set_wake" field of the irq_chip struct before calling
> >> set_irq_chip() for all of the IRQs, so that the compat handler
> >> actually gets installed.
>
> Not really sure if this is necessary. Lennert has done the transition to
> irq_data to those _set_wake() functions as well, so it should be OK
> that compat handler doesn't get installed.
>
> Now I'm not against moving this above, just wondering if there were
> any consequences/errors coming out?
Well, our PXA300 device doesn't power up again when it should resume
from suspend. Fine with me if this has been fixed upstream, but I would
still like to get this patch into 2.6.37. I'll try to test upstream as
soon as Linus releases 2.6.38-rc1...
Sven
next prev parent reply other threads:[~2011-01-18 21:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:44 resume regression in 2.6.37 Sven Neumann
2011-01-13 15:44 ` Sven Neumann
2011-01-13 16:28 ` Thomas Gleixner
2011-01-13 16:28 ` Thomas Gleixner
2011-01-13 17:16 ` Sven Neumann
2011-01-13 17:16 ` Sven Neumann
2011-01-13 17:33 ` Thomas Gleixner
2011-01-13 17:33 ` Thomas Gleixner
2011-01-17 10:36 ` Sven Neumann
2011-01-17 10:36 ` Sven Neumann
2011-01-17 12:40 ` Thomas Gleixner
2011-01-17 12:40 ` Thomas Gleixner
2011-01-17 14:04 ` Sven Neumann
2011-01-17 14:04 ` Sven Neumann
2011-01-17 18:41 ` Thomas Gleixner
2011-01-17 18:41 ` Thomas Gleixner
2011-01-17 19:24 ` Lars-Peter Clausen
2011-01-17 19:24 ` Lars-Peter Clausen
2011-01-17 19:59 ` Lars-Peter Clausen
2011-01-17 19:59 ` Lars-Peter Clausen
2011-01-18 8:16 ` Sven Neumann
2011-01-18 8:16 ` Sven Neumann
2011-01-18 8:18 ` [PATCH] pxa3xx: fix PXA GPIO IRQ handling Sven Neumann
2011-01-18 8:18 ` Sven Neumann
2011-01-18 11:06 ` Uwe Kleine-König
2011-01-18 11:06 ` Uwe Kleine-König
2011-01-18 11:47 ` Lars-Peter Clausen
2011-01-18 11:47 ` Lars-Peter Clausen
2011-01-18 12:29 ` [PATCH] ARM: pxa: fix " Sven Neumann
2011-01-18 12:29 ` Sven Neumann
2011-01-18 16:15 ` [PATCH] pxa3xx: fix PXA " Eric Miao
2011-01-18 16:15 ` Eric Miao
2011-01-18 16:20 ` Lennert Buijtenhek
2011-01-18 16:20 ` Lennert Buijtenhek
2011-01-18 21:49 ` Sven Neumann [this message]
2011-01-18 21:49 ` Sven Neumann
2011-01-20 18:48 ` Eric Miao
2011-01-20 18:48 ` Eric Miao
2011-01-20 18:55 ` Eric Miao
2011-01-20 18:55 ` Eric Miao
2011-01-18 8:19 ` resume regression in 2.6.37 Thomas Gleixner
2011-01-18 8:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295387347.20633.3.camel@bender \
--to=s.neumann@raumfeld.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.