All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c
@ 2011-02-20  9:17 Jarkko Nikula
  2011-02-20 20:04   ` Jarkko Nikula
  0 siblings, 1 reply; 19+ messages in thread
From: Jarkko Nikula @ 2011-02-20  9:17 UTC (permalink / raw)
  To: linux-omap; +Cc: Tony Lindgren, Jarkko Nikula, Tomi Valkeinen

There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set.

drivers/built-in.o: In function `sdp2430_panel_disable':
drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
drivers/built-in.o: In function `sdp2430_panel_enable':
drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'

Fix this by adding TWL4030_CORE dependency to CONFIG_MACH_OMAP_2430SDP as
there is no own entry in drivers/video/omap/Kconfig.

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
Quite old issue most probably. Can be triggered in mainline anyway.
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index b9d8a7b..bfdf240 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -132,6 +132,7 @@ config MACH_OMAP_2430SDP
 	depends on SOC_OMAP2430
 	default y
 	select OMAP_PACKAGE_ZAC
+	select TWL4030_CORE
 
 config MACH_OMAP3_BEAGLE
 	bool "OMAP3 BEAGLE board"
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2011-03-02 17:36 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20  9:17 [PATCH] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c Jarkko Nikula
2011-02-20 20:04 ` [PATCH resend] " Jarkko Nikula
2011-02-20 20:04   ` Jarkko Nikula
2011-02-24 21:26   ` Tony Lindgren
2011-02-24 21:26     ` Tony Lindgren
2011-02-28 14:47     ` Jarkko Nikula
2011-02-28 14:47       ` Jarkko Nikula
2011-02-28 15:09       ` Tomi Valkeinen
2011-02-28 15:09         ` Tomi Valkeinen
2011-03-01  1:39         ` Tony Lindgren
2011-03-01  1:39           ` Tony Lindgren
2011-03-01  6:29           ` Tomi Valkeinen
2011-03-01  6:29             ` Tomi Valkeinen
2011-03-02 17:36             ` Tony Lindgren
2011-03-02 17:36               ` Tony Lindgren
2011-03-01  8:40         ` [PATCH] omapfb: " Jarkko Nikula
2011-03-01  8:40           ` Jarkko Nikula
2011-03-02  7:58           ` Tomi Valkeinen
2011-03-02  7:58             ` [PATCH] omapfb: Fix linker error in Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.