From: Daniel Walker <dwalker@fifo99.com>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: davidb@codeaurora.org, bryanh@codeaurora.org,
linux@arm.linux.org.uk, dima@android.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] msm: Add gpio support for 8960
Date: Wed, 23 Mar 2011 19:24:27 -0700 [thread overview]
Message-ID: <1300933467.6117.49.camel@m0nster> (raw)
In-Reply-To: <4D8A88AE.2000701@codeaurora.org>
On Wed, 2011-03-23 at 16:56 -0700, Rohit Vaswani wrote:
> >>
> >> - set_irq_chained_handler(TLMM_SCSS_SUMMARY_IRQ,
> >> + set_irq_chained_handler(TLMM_MSM_SUMMARY_IRQ,
> >> msm_summary_irq_handler);
> > Ok, so looks like a rename. Can you add this to the commit text along
> > with descriptions of everything else your doing?
> Daniel,
> Adding support for 8960 includes making sure that Gpio support remains
> meaningful and at the same time uniform across different boards. Should
> we enumerate the specific changes ?
Should let everyone know exactly what your doing, even breaking up the
changes into specific patches.
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: dwalker@fifo99.com (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: Add gpio support for 8960
Date: Wed, 23 Mar 2011 19:24:27 -0700 [thread overview]
Message-ID: <1300933467.6117.49.camel@m0nster> (raw)
In-Reply-To: <4D8A88AE.2000701@codeaurora.org>
On Wed, 2011-03-23 at 16:56 -0700, Rohit Vaswani wrote:
> >>
> >> - set_irq_chained_handler(TLMM_SCSS_SUMMARY_IRQ,
> >> + set_irq_chained_handler(TLMM_MSM_SUMMARY_IRQ,
> >> msm_summary_irq_handler);
> > Ok, so looks like a rename. Can you add this to the commit text along
> > with descriptions of everything else your doing?
> Daniel,
> Adding support for 8960 includes making sure that Gpio support remains
> meaningful and at the same time uniform across different boards. Should
> we enumerate the specific changes ?
Should let everyone know exactly what your doing, even breaking up the
changes into specific patches.
Daniel
next prev parent reply other threads:[~2011-03-24 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 22:57 [PATCH] msm: Add gpio support for 8960 Rohit Vaswani
2011-03-17 22:57 ` Rohit Vaswani
2011-03-23 12:59 ` Daniel Walker
2011-03-23 12:59 ` Daniel Walker
2011-03-23 23:56 ` Rohit Vaswani
2011-03-23 23:56 ` Rohit Vaswani
2011-03-24 2:24 ` Daniel Walker [this message]
2011-03-24 2:24 ` Daniel Walker
2011-03-24 22:39 ` David Brown
2011-03-24 22:39 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300933467.6117.49.camel@m0nster \
--to=dwalker@fifo99.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dima@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.