All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brown <davidb@codeaurora.org>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: linux@arm.linux.org.uk, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dima@android.com,
	bryanh@codeaurora.org, Daniel Walker <dwalker@fifo99.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] msm: Add gpio support for 8960
Date: Thu, 24 Mar 2011 15:39:13 -0700	[thread overview]
Message-ID: <8yaoc5016um.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1300933467.6117.49.camel@m0nster> (Daniel Walker's message of "Wed, 23 Mar 2011 19:24:27 -0700")

On Wed, Mar 23 2011, Daniel Walker wrote:

> Should let everyone know exactly what your doing, even breaking up the
> changes into specific patches.

Rohit, but other MSM developers as well.  In general, the commit text
needs to be a lot better.  A good test would be to look at each part of
the patch, and ask how that is described by the commit text.  If it
feels like the commit text is describing separate things, the patch
probably needs to be split up.

Please spend some time running 'git log' on other parts of the kernel to
get a feel for what is expected.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: Add gpio support for 8960
Date: Thu, 24 Mar 2011 15:39:13 -0700	[thread overview]
Message-ID: <8yaoc5016um.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1300933467.6117.49.camel@m0nster> (Daniel Walker's message of "Wed, 23 Mar 2011 19:24:27 -0700")

On Wed, Mar 23 2011, Daniel Walker wrote:

> Should let everyone know exactly what your doing, even breaking up the
> changes into specific patches.

Rohit, but other MSM developers as well.  In general, the commit text
needs to be a lot better.  A good test would be to look at each part of
the patch, and ask how that is described by the commit text.  If it
feels like the commit text is describing separate things, the patch
probably needs to be split up.

Please spend some time running 'git log' on other parts of the kernel to
get a feel for what is expected.

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-03-24 22:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 22:57 [PATCH] msm: Add gpio support for 8960 Rohit Vaswani
2011-03-17 22:57 ` Rohit Vaswani
2011-03-23 12:59 ` Daniel Walker
2011-03-23 12:59   ` Daniel Walker
2011-03-23 23:56   ` Rohit Vaswani
2011-03-23 23:56     ` Rohit Vaswani
2011-03-24  2:24     ` Daniel Walker
2011-03-24  2:24       ` Daniel Walker
2011-03-24 22:39       ` David Brown [this message]
2011-03-24 22:39         ` David Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8yaoc5016um.fsf@huya.qualcomm.com \
    --to=davidb@codeaurora.org \
    --cc=bryanh@codeaurora.org \
    --cc=dima@android.com \
    --cc=dwalker@fifo99.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rvaswani@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.