* [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver
@ 2011-04-09 1:53 Sangbeom Kim
2011-04-09 4:45 ` Jassi Brar
2011-04-11 20:15 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Sangbeom Kim @ 2011-04-09 1:53 UTC (permalink / raw)
To: alsa-devel, linux-samsung-soc
Cc: jassisinghbrar, lrg, broonie, kgene.kim, ben-linux, Sangbeom Kim
Fix the inverted clocks handling for pcm cpu driver.
By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
sound/soc/samsung/pcm.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
index 38aac7d..9c7e8b4 100644
--- a/sound/soc/samsung/pcm.c
+++ b/sound/soc/samsung/pcm.c
@@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai,
ctl = readl(regs + S3C_PCM_CTL);
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
- case SND_SOC_DAIFMT_NB_NF:
- /* Nothing to do, NB_NF by default */
+ case SND_SOC_DAIFMT_IB_NF:
+ /* Nothing to do, IB_NF by default */
break;
default:
dev_err(pcm->dev, "Unsupported clock inversion!\n");
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver
2011-04-09 1:53 [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver Sangbeom Kim
@ 2011-04-09 4:45 ` Jassi Brar
2011-04-11 19:53 ` [alsa-devel] " Liam Girdwood
2011-04-11 20:15 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Jassi Brar @ 2011-04-09 4:45 UTC (permalink / raw)
To: Sangbeom Kim
Cc: alsa-devel, linux-samsung-soc, lrg, broonie, kgene.kim, ben-linux
On Sat, Apr 9, 2011 at 7:23 AM, Sangbeom Kim <sbkim73@samsung.com> wrote:
> Fix the inverted clocks handling for pcm cpu driver.
> By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> ---
> sound/soc/samsung/pcm.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> index 38aac7d..9c7e8b4 100644
> --- a/sound/soc/samsung/pcm.c
> +++ b/sound/soc/samsung/pcm.c
> @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai,
> ctl = readl(regs + S3C_PCM_CTL);
>
> switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> - case SND_SOC_DAIFMT_NB_NF:
> - /* Nothing to do, NB_NF by default */
> + case SND_SOC_DAIFMT_IB_NF:
> + /* Nothing to do, IB_NF by default */
Assuming you already compared screenshot
of a scope and what's mentioned in the manual for IB_NF ...
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver
2011-04-09 4:45 ` Jassi Brar
@ 2011-04-11 19:53 ` Liam Girdwood
0 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-04-11 19:53 UTC (permalink / raw)
To: Jassi Brar
Cc: Sangbeom Kim, alsa-devel, kgene.kim, broonie, linux-samsung-soc,
ben-linux
On Sat, 2011-04-09 at 10:15 +0530, Jassi Brar wrote:
> On Sat, Apr 9, 2011 at 7:23 AM, Sangbeom Kim <sbkim73@samsung.com> wrote:
> > Fix the inverted clocks handling for pcm cpu driver.
> > By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
> >
> > Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> > ---
> > sound/soc/samsung/pcm.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> > index 38aac7d..9c7e8b4 100644
> > --- a/sound/soc/samsung/pcm.c
> > +++ b/sound/soc/samsung/pcm.c
> > @@ -350,8 +350,8 @@ static int s3c_pcm_set_fmt(struct snd_soc_dai *cpu_dai,
> > ctl = readl(regs + S3C_PCM_CTL);
> >
> > switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> > - case SND_SOC_DAIFMT_NB_NF:
> > - /* Nothing to do, NB_NF by default */
> > + case SND_SOC_DAIFMT_IB_NF:
> > + /* Nothing to do, IB_NF by default */
>
> Assuming you already compared screenshot
> of a scope and what's mentioned in the manual for IB_NF ...
>
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver
2011-04-09 1:53 [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver Sangbeom Kim
2011-04-09 4:45 ` Jassi Brar
@ 2011-04-11 20:15 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-04-11 20:15 UTC (permalink / raw)
To: Sangbeom Kim
Cc: alsa-devel, linux-samsung-soc, jassisinghbrar, lrg, kgene.kim,
ben-linux
On Sat, Apr 09, 2011 at 10:53:58AM +0900, Sangbeom Kim wrote:
> Fix the inverted clocks handling for pcm cpu driver.
> By using SND_SOC_DAIFMT_NB_NF, Audio noise can be generated on SMDK.
>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-11 20:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-09 1:53 [PATCH] ASoC: SAMSUNG: Fix the inverted clocks handling for pcm driver Sangbeom Kim
2011-04-09 4:45 ` Jassi Brar
2011-04-11 19:53 ` [alsa-devel] " Liam Girdwood
2011-04-11 20:15 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.