All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Timur Tabi <timur@freescale.com>,
	Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Nazarewicz <mina86@mina86.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 1/3] rename alloc_pages_exact()
Date: Tue, 12 Apr 2011 10:11:45 -0700	[thread overview]
Message-ID: <1302628305.8321.2274.camel@nimitz> (raw)
In-Reply-To: <87r597jt45.fsf@gmail.com>

On Wed, 2011-04-13 at 02:07 +0900, Namhyung Kim wrote:
> >                       if (get_order(size) < MAX_ORDER) {
> > -                             table = alloc_pages_exact(size, GFP_ATOMIC);
> > +                             table = get_free_pages_exact(size, GFP_ATOMIC);
> 
> This should be                  table = get_free_pages_exact(GFP_ATOMIC, size);

It's clear that I'm retarded and need to learn how to use sparse.  :)

Thanks!

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Timur Tabi <timur@freescale.com>,
	Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Nazarewicz <mina86@mina86.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 1/3] rename alloc_pages_exact()
Date: Tue, 12 Apr 2011 10:11:45 -0700	[thread overview]
Message-ID: <1302628305.8321.2274.camel@nimitz> (raw)
In-Reply-To: <87r597jt45.fsf@gmail.com>

On Wed, 2011-04-13 at 02:07 +0900, Namhyung Kim wrote:
> >                       if (get_order(size) < MAX_ORDER) {
> > -                             table = alloc_pages_exact(size, GFP_ATOMIC);
> > +                             table = get_free_pages_exact(size, GFP_ATOMIC);
> 
> This should be                  table = get_free_pages_exact(GFP_ATOMIC, size);

It's clear that I'm retarded and need to learn how to use sparse.  :)

Thanks!

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-04-12 17:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 22:03 [PATCH 1/3] rename alloc_pages_exact() Dave Hansen
2011-04-11 22:03 ` Dave Hansen
2011-04-11 22:03 ` [PATCH 2/3] make new alloc_pages_exact() Dave Hansen
2011-04-11 22:03   ` Dave Hansen
2011-04-11 22:22   ` Andrew Morton
2011-04-11 22:22     ` Andrew Morton
2011-04-11 22:36     ` Dave Hansen
2011-04-11 22:36       ` Dave Hansen
2011-04-11 22:42       ` Timur Tabi
2011-04-11 22:42         ` Timur Tabi
2011-04-12 10:28     ` Michal Nazarewicz
2011-04-12 10:28       ` Michal Nazarewicz
2011-04-12 15:04       ` Dave Hansen
2011-04-12 15:04         ` Dave Hansen
2011-04-12 15:58         ` Michal Nazarewicz
2011-04-12 15:58           ` Michal Nazarewicz
2011-04-13 23:23           ` Dave Hansen
2011-04-13 23:23             ` Dave Hansen
2011-04-11 22:03 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-11 22:03   ` Dave Hansen
2011-04-12 10:29   ` Michal Nazarewicz
2011-04-12 10:29     ` Michal Nazarewicz
2011-04-12 15:24     ` Dave Hansen
2011-04-12 15:24       ` Dave Hansen
2011-04-12 15:57       ` Michal Nazarewicz
2011-04-12 15:57         ` Michal Nazarewicz
2011-04-12 17:07 ` [PATCH 1/3] rename alloc_pages_exact() Namhyung Kim
2011-04-12 17:07   ` Namhyung Kim
2011-04-12 17:11   ` Dave Hansen [this message]
2011-04-12 17:11     ` Dave Hansen
  -- strict thread matches above, loose matches on Subject: below --
2011-04-14 20:01 Dave Hansen
2011-04-14 20:01 ` Dave Hansen
2011-04-29 14:17 ` Timur Tabi
2011-04-29 14:17   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302628305.8321.2274.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=mina86@mina86.com \
    --cc=namhyung@gmail.com \
    --cc=rientjes@google.com \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.