From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>,
David Rientjes <rientjes@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact()
Date: Mon, 11 Apr 2011 15:03:48 -0700 [thread overview]
Message-ID: <20110411220348.D0280E4D@kernel> (raw)
In-Reply-To: <20110411220345.9B95067C@kernel>
Michal Nazarewicz noticed that __alloc_pages_exact()'s
__free_page() loop was really close to something he was
using in one of his patches. That made me realize that
it was actually very similar to __free_pages_exact().
This uses __free_pages_exact() in place of the loop
that we had in __alloc_pages_exact(). Since we had to
change the temporary variables around anyway, I gave
them some better names to hopefully address some other
review comments.
---
linux-2.6.git-dave/mm/page_alloc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff -puN mm/page_alloc.c~reuse-free-exact mm/page_alloc.c
--- linux-2.6.git/mm/page_alloc.c~reuse-free-exact 2011-04-11 15:01:17.701822598 -0700
+++ linux-2.6.git-dave/mm/page_alloc.c 2011-04-11 15:01:17.713822594 -0700
@@ -2338,14 +2338,11 @@ struct page *__alloc_pages_exact(gfp_t g
page = alloc_pages(gfp_mask, order);
if (page) {
- struct page *alloc_end = page + (1 << order);
- struct page *used = page + nr_pages;
+ struct page *unused_start = page + nr_pages;
+ int nr_unused = (1 << order) - nr_pages;
split_page(page, order);
- while (used < alloc_end) {
- __free_page(used);
- used++;
- }
+ __free_pages_exact(unused_start, nr_unused);
}
return page;
_
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>,
David Rientjes <rientjes@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact()
Date: Mon, 11 Apr 2011 15:03:48 -0700 [thread overview]
Message-ID: <20110411220348.D0280E4D@kernel> (raw)
In-Reply-To: <20110411220345.9B95067C@kernel>
Michal Nazarewicz noticed that __alloc_pages_exact()'s
__free_page() loop was really close to something he was
using in one of his patches. That made me realize that
it was actually very similar to __free_pages_exact().
This uses __free_pages_exact() in place of the loop
that we had in __alloc_pages_exact(). Since we had to
change the temporary variables around anyway, I gave
them some better names to hopefully address some other
review comments.
---
linux-2.6.git-dave/mm/page_alloc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff -puN mm/page_alloc.c~reuse-free-exact mm/page_alloc.c
--- linux-2.6.git/mm/page_alloc.c~reuse-free-exact 2011-04-11 15:01:17.701822598 -0700
+++ linux-2.6.git-dave/mm/page_alloc.c 2011-04-11 15:01:17.713822594 -0700
@@ -2338,14 +2338,11 @@ struct page *__alloc_pages_exact(gfp_t g
page = alloc_pages(gfp_mask, order);
if (page) {
- struct page *alloc_end = page + (1 << order);
- struct page *used = page + nr_pages;
+ struct page *unused_start = page + nr_pages;
+ int nr_unused = (1 << order) - nr_pages;
split_page(page, order);
- while (used < alloc_end) {
- __free_page(used);
- used++;
- }
+ __free_pages_exact(unused_start, nr_unused);
}
return page;
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-11 22:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 22:03 [PATCH 1/3] rename alloc_pages_exact() Dave Hansen
2011-04-11 22:03 ` Dave Hansen
2011-04-11 22:03 ` [PATCH 2/3] make new alloc_pages_exact() Dave Hansen
2011-04-11 22:03 ` Dave Hansen
2011-04-11 22:22 ` Andrew Morton
2011-04-11 22:22 ` Andrew Morton
2011-04-11 22:36 ` Dave Hansen
2011-04-11 22:36 ` Dave Hansen
2011-04-11 22:42 ` Timur Tabi
2011-04-11 22:42 ` Timur Tabi
2011-04-12 10:28 ` Michal Nazarewicz
2011-04-12 10:28 ` Michal Nazarewicz
2011-04-12 15:04 ` Dave Hansen
2011-04-12 15:04 ` Dave Hansen
2011-04-12 15:58 ` Michal Nazarewicz
2011-04-12 15:58 ` Michal Nazarewicz
2011-04-13 23:23 ` Dave Hansen
2011-04-13 23:23 ` Dave Hansen
2011-04-11 22:03 ` Dave Hansen [this message]
2011-04-11 22:03 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-12 10:29 ` Michal Nazarewicz
2011-04-12 10:29 ` Michal Nazarewicz
2011-04-12 15:24 ` Dave Hansen
2011-04-12 15:24 ` Dave Hansen
2011-04-12 15:57 ` Michal Nazarewicz
2011-04-12 15:57 ` Michal Nazarewicz
2011-04-12 17:07 ` [PATCH 1/3] rename alloc_pages_exact() Namhyung Kim
2011-04-12 17:07 ` Namhyung Kim
2011-04-12 17:11 ` Dave Hansen
2011-04-12 17:11 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2011-04-14 20:01 Dave Hansen
2011-04-14 20:01 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-14 20:01 ` Dave Hansen
2011-04-14 22:00 ` David Rientjes
2011-04-14 22:00 ` David Rientjes
2011-04-14 22:07 ` Dave Hansen
2011-04-14 22:07 ` Dave Hansen
2011-04-14 22:09 ` David Rientjes
2011-04-14 22:09 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411220348.D0280E4D@kernel \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=rientjes@google.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.