From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>
Subject: Re: [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact()
Date: Thu, 14 Apr 2011 15:07:05 -0700 [thread overview]
Message-ID: <1302818825.16562.1094.camel@nimitz> (raw)
In-Reply-To: <alpine.DEB.2.00.1104141459510.13286@chino.kir.corp.google.com>
On Thu, 2011-04-14 at 15:00 -0700, David Rientjes wrote:
> On Thu, 14 Apr 2011, Dave Hansen wrote:
> > Michal Nazarewicz noticed that __alloc_pages_exact()'s
> > __free_page() loop was really close to something he was
> > using in one of his patches. That made me realize that
> > it was actually very similar to __free_pages_exact().
> >
> > This uses __free_pages_exact() in place of the loop
> > that we had in __alloc_pages_exact(). Since we had to
> > change the temporary variables around anyway, I gave
> > them some better names to hopefully address some other
> > review comments.
>
> No signed-off-by?
Bah, sorry. I'll resend the whole sucker, with sob if anybody wants.
Otherwise:
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@freescale.com>,
Andi Kleen <andi@firstfloor.org>, Mel Gorman <mel@csn.ul.ie>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>
Subject: Re: [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact()
Date: Thu, 14 Apr 2011 15:07:05 -0700 [thread overview]
Message-ID: <1302818825.16562.1094.camel@nimitz> (raw)
In-Reply-To: <alpine.DEB.2.00.1104141459510.13286@chino.kir.corp.google.com>
On Thu, 2011-04-14 at 15:00 -0700, David Rientjes wrote:
> On Thu, 14 Apr 2011, Dave Hansen wrote:
> > Michal Nazarewicz noticed that __alloc_pages_exact()'s
> > __free_page() loop was really close to something he was
> > using in one of his patches. That made me realize that
> > it was actually very similar to __free_pages_exact().
> >
> > This uses __free_pages_exact() in place of the loop
> > that we had in __alloc_pages_exact(). Since we had to
> > change the temporary variables around anyway, I gave
> > them some better names to hopefully address some other
> > review comments.
>
> No signed-off-by?
Bah, sorry. I'll resend the whole sucker, with sob if anybody wants.
Otherwise:
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-14 22:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 20:01 [PATCH 1/3] rename alloc_pages_exact() Dave Hansen
2011-04-14 20:01 ` Dave Hansen
2011-04-14 20:01 ` [PATCH 2/3] make new alloc_pages_exact() Dave Hansen
2011-04-14 20:01 ` Dave Hansen
2011-04-14 21:55 ` David Rientjes
2011-04-14 21:55 ` David Rientjes
2011-04-27 21:30 ` Timur Tabi
2011-04-27 21:30 ` Timur Tabi
2011-04-27 21:37 ` Dave Hansen
2011-04-27 21:37 ` Dave Hansen
2011-04-27 21:42 ` Timur Tabi
2011-04-27 21:42 ` Timur Tabi
2011-04-28 16:02 ` Dave Hansen
2011-04-28 16:02 ` Dave Hansen
2011-04-14 20:01 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-14 20:01 ` Dave Hansen
2011-04-14 22:00 ` David Rientjes
2011-04-14 22:00 ` David Rientjes
2011-04-14 22:07 ` Dave Hansen [this message]
2011-04-14 22:07 ` Dave Hansen
2011-04-14 22:09 ` David Rientjes
2011-04-14 22:09 ` David Rientjes
2011-04-29 14:17 ` [PATCH 1/3] rename alloc_pages_exact() Timur Tabi
2011-04-29 14:17 ` Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2011-04-11 22:03 Dave Hansen
2011-04-11 22:03 ` [PATCH 3/3] reuse __free_pages_exact() in __alloc_pages_exact() Dave Hansen
2011-04-11 22:03 ` Dave Hansen
2011-04-12 10:29 ` Michal Nazarewicz
2011-04-12 10:29 ` Michal Nazarewicz
2011-04-12 15:24 ` Dave Hansen
2011-04-12 15:24 ` Dave Hansen
2011-04-12 15:57 ` Michal Nazarewicz
2011-04-12 15:57 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302818825.16562.1094.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=rientjes@google.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.