From: Alex Williamson <alex.williamson@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Cc: pugs@ieee.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, qemu-devel@nongnu.org,
aafabbri@cisco.com, dwang2@cisco.com, benve@cisco.com
Subject: Re: [PATCH] vfio: Add an ioctl to reset the device
Date: Tue, 19 Apr 2011 16:22:31 -0600 [thread overview]
Message-ID: <1303251751.3110.129.camel@x201> (raw)
In-Reply-To: <20110419220743.GO12133@x200.localdomain>
On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote:
> * Alex Williamson (alex.williamson@redhat.com) wrote:
> > When using VFIO to assign a device to a guest, we want to make sure
> > the device is quiesced on VM reset to stop all DMA within the guest
> > mapped memory. Add an ioctl which just calls pci_reset_function()
> > and returns whether it succeeds.
>
> Shouldn't there be a reset when binding/unbinding vfio to/from a pci
> device?
There's already one when the /dev/vfioX file is opened, we should add
another on release, and probably add the same PCI save state store/load
that I'm proposing for KVM across those. Thanks,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, aafabbri@cisco.com, dwang2@cisco.com,
pugs@ieee.org, benve@cisco.com
Subject: Re: [Qemu-devel] [PATCH] vfio: Add an ioctl to reset the device
Date: Tue, 19 Apr 2011 16:22:31 -0600 [thread overview]
Message-ID: <1303251751.3110.129.camel@x201> (raw)
In-Reply-To: <20110419220743.GO12133@x200.localdomain>
On Tue, 2011-04-19 at 15:07 -0700, Chris Wright wrote:
> * Alex Williamson (alex.williamson@redhat.com) wrote:
> > When using VFIO to assign a device to a guest, we want to make sure
> > the device is quiesced on VM reset to stop all DMA within the guest
> > mapped memory. Add an ioctl which just calls pci_reset_function()
> > and returns whether it succeeds.
>
> Shouldn't there be a reset when binding/unbinding vfio to/from a pci
> device?
There's already one when the /dev/vfioX file is opened, we should add
another on release, and probably add the same PCI save state store/load
that I'm proposing for KVM across those. Thanks,
Alex
next prev parent reply other threads:[~2011-04-19 22:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 20:32 [PATCH] vfio: Add an ioctl to reset the device Alex Williamson
2011-04-19 20:32 ` [Qemu-devel] " Alex Williamson
2011-04-19 21:40 ` Randy Dunlap
2011-04-19 21:40 ` [Qemu-devel] " Randy Dunlap
2011-04-19 21:43 ` Chris Wright
2011-04-19 21:43 ` [Qemu-devel] " Chris Wright
2011-04-19 22:07 ` Chris Wright
2011-04-19 22:07 ` [Qemu-devel] " Chris Wright
2011-04-19 22:22 ` Alex Williamson [this message]
2011-04-19 22:22 ` Alex Williamson
2011-04-19 22:26 ` Chris Wright
2011-04-19 22:26 ` [Qemu-devel] " Chris Wright
2011-04-19 22:30 ` Alex Williamson
2011-04-19 22:30 ` [Qemu-devel] " Alex Williamson
2011-04-19 22:37 ` Chris Wright
2011-04-19 22:37 ` [Qemu-devel] " Chris Wright
2011-04-19 23:23 ` Tom Lyon
2011-04-19 23:23 ` [Qemu-devel] " Tom Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303251751.3110.129.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=aafabbri@cisco.com \
--cc=benve@cisco.com \
--cc=chrisw@redhat.com \
--cc=dwang2@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pugs@ieee.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.