From: Alex Williamson <alex.williamson@redhat.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/lvds: Only act on lid notify when the device is on
Date: Sun, 24 Apr 2011 07:26:46 -0600 [thread overview]
Message-ID: <1303651606.3431.4.camel@x201> (raw)
In-Reply-To: <b7da2f$r79lnn@fmsmga001.fm.intel.com>
On Sun, 2011-04-24 at 11:05 +0100, Chris Wilson wrote:
> On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson <alex.williamson@redhat.com> wrote:
> > If we're using vga switcheroo, the device may be turned off
> > and poking at it can cause an oops.
>
> I added just a couple more details to the changelog and added to my -fixes
> queue.
>
> The question for the audience is: what is the difference between using the
> PCI power state and the drm->power_switch_state?
Seems possible we could use either. I picked the latter because
i915_switcheroo_set_state() seems to be keeping it in sync with power
state and has the "changing" state, which might help reduce races.
Thanks,
Alex
prev parent reply other threads:[~2011-04-24 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 22:08 [PATCH] drm/i915/lvds: Only act on lid notify when the device is on Alex Williamson
2011-04-22 5:58 ` Chris Wilson
2011-04-22 6:13 ` Dave Airlie
2011-04-22 6:26 ` Chris Wilson
2011-04-23 14:42 ` Alex Williamson
2011-04-24 10:05 ` Chris Wilson
2011-04-24 13:26 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303651606.3431.4.camel@x201 \
--to=alex.williamson@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.