From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/lvds: Only act on lid notify when the device is on
Date: Fri, 22 Apr 2011 07:26:48 +0100 [thread overview]
Message-ID: <849307$ck36v0@azsmga001.ch.intel.com> (raw)
In-Reply-To: <BANLkTin7xse0fG_2BVrt4yOJrYvh83zc2A@mail.gmail.com>
On Fri, 22 Apr 2011 16:13:27 +1000, Dave Airlie <airlied@gmail.com> wrote:
> On Fri, Apr 22, 2011 at 3:58 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson <alex.williamson@redhat.com> wrote:
> >> If we're using vga switcheroo, the device may be turned off
> >> and poking at it can cause an oops.
> >
> > I'm unfamiliar with what actually happens here after it is turned off. Can
> > you post an OOPS for an example?
>
> The device will be in D3, so I'm guessing we read back some register
> and get 0xFFFFFFFF,
> and later fail.
That's sounds reasonable. A bit of explanation does wonders if I (or
anyone else reading through the history *or* code) ever encounter
similar bug reports.
Is anyone else concerned by the acpi_lid_notifier never being decoupled
when the module is unloaded? And the randomness of int_lvds_connector?
I love our code, every time you read it you find another bug.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-22 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 22:08 [PATCH] drm/i915/lvds: Only act on lid notify when the device is on Alex Williamson
2011-04-22 5:58 ` Chris Wilson
2011-04-22 6:13 ` Dave Airlie
2011-04-22 6:26 ` Chris Wilson [this message]
2011-04-23 14:42 ` Alex Williamson
2011-04-24 10:05 ` Chris Wilson
2011-04-24 13:26 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='849307$ck36v0@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.