All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless <linux-wireless@vger.kernel.org>
Cc: Javier Cardona <javier@cozybit.com>
Subject: mesh RCU issues
Date: Thu, 12 May 2011 14:25:38 +0200	[thread overview]
Message-ID: <1305203138.3461.24.camel@jlt3.sipsolutions.net> (raw)

I was reviewing sparse RCU warnings in mac80211...

This seems to be some kind of bad joke:

void mesh_path_timer(unsigned long data)
{
        struct ieee80211_sub_if_data *sdata;
        struct mesh_path *mpath;
   
        rcu_read_lock();
        mpath = (struct mesh_path *) data;
        mpath = rcu_dereference(mpath);
        if (!mpath)
                goto endmpathtimer;

????

And indeed I don't see a del_timer_sync() when the mesh path is freed.
But this is _clearly_ totally bogus. Somebody please fix ASAP.

johannes


             reply	other threads:[~2011-05-12 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 12:25 Johannes Berg [this message]
2011-05-12 13:03 ` [PATCH] mac80211: remove pointless mesh path timer RCU code Johannes Berg
2011-05-12 22:26 ` mesh RCU issues Javier Cardona
2011-05-13  7:13   ` Johannes Berg
2011-05-13 20:28     ` Javier Cardona
2011-05-13 23:30       ` Johannes Berg
2011-05-14  0:00       ` Johannes Berg
2011-05-14  3:52         ` Javier Cardona
2011-05-14  8:24           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305203138.3461.24.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=javier@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.