All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	devel@lists.open80211s.org
Subject: Re: mesh RCU issues
Date: Fri, 13 May 2011 09:13:13 +0200	[thread overview]
Message-ID: <1305270793.3487.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTinDyLyVX3HFHU7i4GFUi8SixOdzAQ@mail.gmail.com> (sfid-20110513_002720_483327_839FC15E)

On Thu, 2011-05-12 at 15:26 -0700, Javier Cardona wrote:

> > And indeed I don't see a del_timer_sync() when the mesh path is freed.
> 
> Isn't the call to del_timer_sync() you are looking for in
> mesh_path_node_reclaim() ?

Hmm, indeed, but it looks like mesh_path_node_free() also frees a node,
no? I'd only found the latter function freeing it and got worried.

> > But this is _clearly_ totally bogus. Somebody please fix ASAP.
> 
> I'll run sparse and see if I see other rcu warnings that I can fix.

Thanks. I think most of the use is probably OK or "just" missing
rcu_dereference() wrappers. The global mesh_paths and mpp_paths
variables should also be __rcu I think, but that caused so many warnings
that I gave up for now, and I didn't quite understand what was going on.

You'll want to apply
http://johannes.sipsolutions.net/patches/kernel/all/LATEST/NNN-mac80211-rcu-annotations.patch to get rid of all the other spurious RCU warnings with CONFIG_SPARSE_RCU.

Thanks,
Johannes


  reply	other threads:[~2011-05-13  7:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 12:25 mesh RCU issues Johannes Berg
2011-05-12 13:03 ` [PATCH] mac80211: remove pointless mesh path timer RCU code Johannes Berg
2011-05-12 22:26 ` mesh RCU issues Javier Cardona
2011-05-13  7:13   ` Johannes Berg [this message]
2011-05-13 20:28     ` Javier Cardona
2011-05-13 23:30       ` Johannes Berg
2011-05-14  0:00       ` Johannes Berg
2011-05-14  3:52         ` Javier Cardona
2011-05-14  8:24           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305270793.3487.3.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=devel@lists.open80211s.org \
    --cc=javier@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.