From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
devel@lists.open80211s.org
Subject: Re: mesh RCU issues
Date: Sat, 14 May 2011 10:24:33 +0200 [thread overview]
Message-ID: <1305361473.3437.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTinYGGnGoE2jeuAmEYGW7HyBsV2+BA@mail.gmail.com> (sfid-20110514_055323_305661_D0C3EC53)
On Fri, 2011-05-13 at 20:52 -0700, Javier Cardona wrote:
> > With this patch, I get the warnings below.
>
> Thanks. Any ideas on how to fix sparse? I'd like to see those too :)
No, not really, what version are you using? I'm on 64 bit so I don't
have uaccess_32.h included I guess, I suppose you could just go to that
file and comment out the contents of the copy_from_user_overflow()
function that seems to be causing it grief.
> > The locking ones are definitely genuine bugs,
>
> I'm not sure I fully understand the sparse message... would this fix
> the two locking warnings?
[snip]
Sure, those locking fixes should fix the bugs and get rid of the
warnings unless there was another code path leaving w/o unlock.
johannes
prev parent reply other threads:[~2011-05-14 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 12:25 mesh RCU issues Johannes Berg
2011-05-12 13:03 ` [PATCH] mac80211: remove pointless mesh path timer RCU code Johannes Berg
2011-05-12 22:26 ` mesh RCU issues Javier Cardona
2011-05-13 7:13 ` Johannes Berg
2011-05-13 20:28 ` Javier Cardona
2011-05-13 23:30 ` Johannes Berg
2011-05-14 0:00 ` Johannes Berg
2011-05-14 3:52 ` Javier Cardona
2011-05-14 8:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305361473.3437.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.