From: Chris Mason <chris.mason@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Btrfs updates
Date: Sun, 12 Jun 2011 21:52:21 -0400 [thread overview]
Message-ID: <1307929838-sup-4118@shiny> (raw)
In-Reply-To: <m262oar1a9.fsf@firstfloor.org>
Excerpts from Andi Kleen's message of 2011-06-12 21:02:54 -0400:
> Chris Mason <chris.mason@oracle.com> writes:
>=20
> > Hi everyone,
> >
> > The for-linus branch of the btrfs unstable tree:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.=
git for-linus
>=20
> >
> > Has our current queue of fixes. Josef's is the biggest pile, mostl=
y in
> > the allocator. Josef and I both managed to merge his patch to avoi=
d
> > mapping the extent buffer if skip_locking was set, git merge is jus=
t a
> > little too easy sometimes (I double checked the resulting code).
>=20
> The new in 3.0 btrfs warnings on every build are still there:
>=20
> fs/btrfs/sysfs.c:76: warning: =E2=80=98btrfs_root_attrs=E2=80=99 defi=
ned but not used
> fs/btrfs/sysfs.c:97: warning: =E2=80=98btrfs_super_attrs=E2=80=99 def=
ined but not used
> fs/btrfs/sysfs.c:153: warning: =E2=80=98btrfs_super_release=E2=80=99 =
defined but not used =20
> fs/btrfs/sysfs.c:160: warning: =E2=80=98btrfs_root_release=E2=80=99 d=
efined but not used
>=20
> These are not even used inside any ifdef. It's unclear to me: were
> these supposed to be used or removed?
>=20
> Probably better to remove since they seem to be untested, unless
> it was a merge error?
Right, I've been trying to decide how much of the sysfs interface to ri=
p
out. We're not using it the way I had planned to, and Kay's proposed
udev changes are better than my original plans for sysfs.
One way or another I'll kill these off in the next rc.
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Btrfs updates
Date: Sun, 12 Jun 2011 21:52:21 -0400 [thread overview]
Message-ID: <1307929838-sup-4118@shiny> (raw)
In-Reply-To: <m262oar1a9.fsf@firstfloor.org>
Excerpts from Andi Kleen's message of 2011-06-12 21:02:54 -0400:
> Chris Mason <chris.mason@oracle.com> writes:
>
> > Hi everyone,
> >
> > The for-linus branch of the btrfs unstable tree:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git for-linus
>
> >
> > Has our current queue of fixes. Josef's is the biggest pile, mostly in
> > the allocator. Josef and I both managed to merge his patch to avoid
> > mapping the extent buffer if skip_locking was set, git merge is just a
> > little too easy sometimes (I double checked the resulting code).
>
> The new in 3.0 btrfs warnings on every build are still there:
>
> fs/btrfs/sysfs.c:76: warning: ‘btrfs_root_attrs’ defined but not used
> fs/btrfs/sysfs.c:97: warning: ‘btrfs_super_attrs’ defined but not used
> fs/btrfs/sysfs.c:153: warning: ‘btrfs_super_release’ defined but not used
> fs/btrfs/sysfs.c:160: warning: ‘btrfs_root_release’ defined but not used
>
> These are not even used inside any ifdef. It's unclear to me: were
> these supposed to be used or removed?
>
> Probably better to remove since they seem to be untested, unless
> it was a merge error?
Right, I've been trying to decide how much of the sysfs interface to rip
out. We're not using it the way I had planned to, and Kay's proposed
udev changes are better than my original plans for sysfs.
One way or another I'll kill these off in the next rc.
-chris
next prev parent reply other threads:[~2011-06-13 1:52 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 11:57 [GIT PULL] Btrfs updates Chris Mason
2011-06-12 18:08 ` Linus Torvalds
2011-06-13 1:02 ` Andi Kleen
2011-06-13 1:02 ` Andi Kleen
2011-06-13 1:52 ` Chris Mason [this message]
2011-06-13 1:52 ` Chris Mason
2011-06-13 2:05 ` Li Zefan
2011-06-13 2:05 ` Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2013-05-18 14:30 Chris Mason
2013-03-29 17:47 Chris Mason
2013-03-09 0:38 Chris Mason
2013-02-16 1:55 Chris Mason
2012-12-17 21:44 Chris Mason
2012-12-19 18:09 ` Roy Sigurd Karlsbakk
2012-12-19 19:07 ` Hugo Mills
2012-12-17 21:28 Chris Mason
2012-08-29 16:01 Chris Mason
2012-07-05 19:55 Chris Mason
2012-06-21 15:47 Chris Mason
2012-06-15 18:09 Chris Mason
2012-06-15 23:57 ` Linus Torvalds
2012-06-16 0:21 ` Chris Mason
2012-06-01 13:18 Chris Mason
2012-04-13 13:38 Chris Mason
2012-04-16 1:19 ` Tsutomu Itoh
2012-03-10 2:01 Chris Mason
2012-02-24 16:41 Chris Mason
2011-12-01 15:39 Chris Mason
2011-12-05 8:10 ` Miao Xie
2011-12-05 13:14 ` Chris Mason
2011-12-05 14:08 ` David Sterba
2011-12-06 3:25 ` Miao Xie
2011-08-18 18:04 Chris Mason
2011-08-18 21:51 ` Sage Weil
2011-08-20 14:01 ` Chris Mason
2011-07-27 22:46 Chris Mason
2011-06-27 18:15 Chris Mason
2011-06-20 1:12 Chris Mason
2011-06-04 14:37 Chris Mason
2011-05-27 19:55 Chris Mason
2011-05-27 21:44 ` Chester
2011-05-27 21:44 ` Chester
2011-05-15 14:47 Chris Mason
2011-05-15 15:41 ` kehon
2011-04-26 14:24 Chris Mason
2011-04-18 14:26 Chris Mason
2011-02-15 3:49 Chris Mason
2011-02-07 20:12 Chris Mason
2011-02-08 20:05 ` Helmut Hullen
2011-01-17 21:13 Chris Mason
2011-01-18 10:14 ` Felix Blanke
2011-01-18 15:22 ` C Anthony Risinger
2011-01-18 17:56 ` Mitch Harder
2011-01-18 18:51 ` C Anthony Risinger
2011-01-19 9:15 ` Spelic
2011-01-22 23:41 ` Clemens Eisserer
2011-01-22 23:53 ` cwillu
2011-01-18 18:55 ` Goffredo Baroncelli
2011-03-09 22:01 ` Diego Calleja
2010-12-14 1:54 Chris Mason
2010-05-27 15:15 Chris Mason
2010-05-27 17:18 ` Linus Torvalds
2010-05-27 17:32 ` Chris Mason
2010-05-27 17:47 ` Linus Torvalds
2010-06-02 2:59 ` Miao Xie
2010-09-12 12:38 ` Felipe Contreras
2010-09-12 12:38 ` Felipe Contreras
2010-09-12 12:38 ` Felipe Contreras
2010-04-05 19:36 Chris Mason
2010-04-06 15:40 ` Chris Mason
2010-03-15 19:18 Chris Mason
2010-03-16 21:01 ` Chris Mason
2010-03-18 16:59 ` Chris Mason
2009-10-15 0:06 Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307929838-sup-4118@shiny \
--to=chris.mason@oracle.com \
--cc=andi@firstfloor.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.