Re: [PATCH_v2] plugins: update ofono rule and udev for using speedupcdma

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hi Guillaume,

> -# SpeedUp
> -ATTRS{idVendor}=="1c9e", ENV{OFONO_DRIVER}="speedup"
> +# SpeedUp 7300
> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9e00", ENV{OFONO_DRIVER}="speedupcdma"
> +
> +# SpeedUp 9800
> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9800", ENV{OFONO_DRIVER}="speedup"
>  
> -ATTRS{idVendor}=="1c9e", ATTRS{serial}=="1234567890ABCDEF", ENV{ID_SERIAL_SHORT}=""
> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9800", ATTRS{serial}=="1234567890ABCDEF", ENV{ID_SERIAL_SHORT}=""

is the serial number really fake. Adding the content of usb-devices
script for this specific modem would help here.

Or has this just been copied over from the Huawei entries and we missed
it in the review?
 
>  ATTRS{idVendor}=="2020", ENV{OFONO_DRIVER}="speedup"
>  
> diff --git a/plugins/udev.c b/plugins/udev.c
> index a28bea7..b50ca2f 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -793,6 +793,8 @@ done:
>  		add_linktop(modem, udev_device);
>          else if (g_strcmp0(driver, "speedup") == 0)
>  		add_speedup(modem, udev_device);
> +	else if (g_strcmp0(driver, "speedupcdma") == 0)
> +		add_speedup(modem, udev_device);

Coding style mistake here. Tabs vs spaces.

Regards

Marcel