Re: [PATCH_v2] plugins: update ofono rule and udev for using speedupcdma

[Guillaume Zajac <guillaume.zajac@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi Marcel,

On 20/07/2011 13:02, Marcel Holtmann wrote:
> Hi Guillaume,
>
>> -# SpeedUp
>> -ATTRS{idVendor}=="1c9e", ENV{OFONO_DRIVER}="speedup"
>> +# SpeedUp 7300
>> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9e00", ENV{OFONO_DRIVER}="speedupcdma"
>> +
>> +# SpeedUp 9800
>> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9800", ENV{OFONO_DRIVER}="speedup"
>>
>> -ATTRS{idVendor}=="1c9e", ATTRS{serial}=="1234567890ABCDEF", ENV{ID_SERIAL_SHORT}=""
>> +ATTRS{idVendor}=="1c9e", ATTRS{idProduct}=="9800", ATTRS{serial}=="1234567890ABCDEF", ENV{ID_SERIAL_SHORT}=""
> is the serial number really fake. Adding the content of usb-devices
> script for this specific modem would help here.
>
> Or has this just been copied over from the Huawei entries and we missed
> it in the review?

Sorry I committed a wrong patch, I will send you the right version of 
this patch later.
This serial, is not a fake, in using usb-devices with the dongle I got 
before usb_modeswitch:

T:  Bus=02 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 84 Spd=480 MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=1c9e ProdID=9800 Rev=00.00
S:  Manufacturer=USB Modem
S:  Product=USB Modem
S:  SerialNumber=1234567890ABCDEF
C:  #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
I:  If#= 0 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
I:  If#= 1 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage


>
>>   ATTRS{idVendor}=="2020", ENV{OFONO_DRIVER}="speedup"
>>
>> diff --git a/plugins/udev.c b/plugins/udev.c
>> index a28bea7..b50ca2f 100644
>> --- a/plugins/udev.c
>> +++ b/plugins/udev.c
>> @@ -793,6 +793,8 @@ done:
>>   		add_linktop(modem, udev_device);
>>           else if (g_strcmp0(driver, "speedup") == 0)
>>   		add_speedup(modem, udev_device);
>> +	else if (g_strcmp0(driver, "speedupcdma") == 0)
>> +		add_speedup(modem, udev_device);
> Coding style mistake here. Tabs vs spaces.
>
> Regards
>
> Marcel
>

Kind regards,
Guillaume