From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH_v3] speedupcdma: add speedup cdma skeleton plugin
Date: Wed, 20 Jul 2011 13:47:42 +0200 [thread overview]
Message-ID: <1311162463.21109.211.camel@aeonflux> (raw)
In-Reply-To: <1311159814-15997-1-git-send-email-guillaume.zajac@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
Hi Guillaume,
> Remove unused variable into speedupcdma_remove()
<snip>
> +static void speedupcdma_remove(struct ofono_modem *modem)
> +{
> + DBG("%p", modem);
> +
> + ofono_modem_set_data(modem, NULL);
> +}
You do actually have to free the data. Otherwise you are leaking memory.
Regards
Marcel
prev parent reply other threads:[~2011-07-20 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 10:51 [PATCH_v2] plugins: update ofono rule and udev for using speedupcdma Guillaume Zajac
2011-07-20 11:02 ` Marcel Holtmann
2011-07-20 11:07 ` Guillaume Zajac
2011-07-20 11:47 ` Marcel Holtmann
2011-07-20 11:03 ` [PATCH_v3] speedupcdma: add speedup cdma skeleton plugin Guillaume Zajac
2011-07-20 11:47 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311162463.21109.211.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.