All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	hughd@google.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1
Date: Sun, 31 Jul 2011 23:45:46 +0300	[thread overview]
Message-ID: <1312145146.24862.97.camel@jaguar> (raw)
In-Reply-To: <alpine.DEB.2.00.1107311253560.12538@chino.kir.corp.google.com>

On Sun, 2011-07-31 at 13:24 -0700, David Rientjes wrote:
> And although slub is definitely heading in the right direction regarding 
> the netperf benchmark, it's still a non-starter for anybody using large 
> NUMA machines for networking performance.  On my 16-core, 4 node, 64GB 
> client/server machines running netperf TCP_RR with various thread counts 
> for 60 seconds each on 3.0:
> 
> 	threads		SLUB		SLAB		diff
> 	 16		76345		74973		- 1.8%
> 	 32		116380		116272		- 0.1%
> 	 48		150509		153703		+ 2.1%
> 	 64		187984		189750		+ 0.9%
> 	 80		216853		224471		+ 3.5%
> 	 96		236640		249184		+ 5.3%
> 	112		256540		275464		+ 7.4%
> 	128		273027		296014		+ 8.4%
> 	144		281441		314791		+11.8%
> 	160		287225		326941		+13.8%

That looks like a pretty nasty scaling issue. David, would it be
possible to see 'perf report' for the 160 case? [ Maybe even 'perf
annotate' for the interesting SLUB functions. ]

On Sun, 2011-07-31 at 13:24 -0700, David Rientjes wrote:
> And although I've developed a mutable slab allocator, SLAM, that makes all 
> of this irrelevant since it's a drop-in replacement for slab and slub, I 
> can't legitimately propose it for inclusion because it lacks the debugging 
> capabilities that slub excels in and there's an understanding that Linus 
> won't merge another stand-alone allocator until one is removed.

Nick tried that with SLQB and it didn't work out. I actually even tried
to maintain it out-of-tree for a while but eventually gave up. So no,
I'm not interested in merging a new allocator either. I would be,
however, interested to see the source code.

			Pekka


WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	hughd@google.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1
Date: Sun, 31 Jul 2011 23:45:46 +0300	[thread overview]
Message-ID: <1312145146.24862.97.camel@jaguar> (raw)
In-Reply-To: <alpine.DEB.2.00.1107311253560.12538@chino.kir.corp.google.com>

On Sun, 2011-07-31 at 13:24 -0700, David Rientjes wrote:
> And although slub is definitely heading in the right direction regarding 
> the netperf benchmark, it's still a non-starter for anybody using large 
> NUMA machines for networking performance.  On my 16-core, 4 node, 64GB 
> client/server machines running netperf TCP_RR with various thread counts 
> for 60 seconds each on 3.0:
> 
> 	threads		SLUB		SLAB		diff
> 	 16		76345		74973		- 1.8%
> 	 32		116380		116272		- 0.1%
> 	 48		150509		153703		+ 2.1%
> 	 64		187984		189750		+ 0.9%
> 	 80		216853		224471		+ 3.5%
> 	 96		236640		249184		+ 5.3%
> 	112		256540		275464		+ 7.4%
> 	128		273027		296014		+ 8.4%
> 	144		281441		314791		+11.8%
> 	160		287225		326941		+13.8%

That looks like a pretty nasty scaling issue. David, would it be
possible to see 'perf report' for the 160 case? [ Maybe even 'perf
annotate' for the interesting SLUB functions. ]

On Sun, 2011-07-31 at 13:24 -0700, David Rientjes wrote:
> And although I've developed a mutable slab allocator, SLAM, that makes all 
> of this irrelevant since it's a drop-in replacement for slab and slub, I 
> can't legitimately propose it for inclusion because it lacks the debugging 
> capabilities that slub excels in and there's an understanding that Linus 
> won't merge another stand-alone allocator until one is removed.

Nick tried that with SLQB and it didn't work out. I actually even tried
to maintain it out-of-tree for a while but eventually gave up. So no,
I'm not interested in merging a new allocator either. I would be,
however, interested to see the source code.

			Pekka

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-31 20:45 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28 22:47 [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1 Pekka Enberg
2011-07-28 22:47 ` Pekka Enberg
2011-07-29 15:04 ` Christoph Lameter
2011-07-29 15:04   ` Christoph Lameter
2011-07-29 23:18   ` Andi Kleen
2011-07-29 23:18     ` Andi Kleen
2011-07-30  6:33     ` Eric Dumazet
2011-07-30  6:33       ` Eric Dumazet
2011-07-31 18:50   ` David Rientjes
2011-07-31 18:50     ` David Rientjes
2011-07-31 20:24     ` David Rientjes
2011-07-31 20:24       ` David Rientjes
2011-07-31 20:45       ` Pekka Enberg [this message]
2011-07-31 20:45         ` Pekka Enberg
2011-07-31 21:55         ` David Rientjes
2011-07-31 21:55           ` David Rientjes
2011-08-01  5:08           ` Pekka Enberg
2011-08-01  5:08             ` Pekka Enberg
2011-08-01 10:02             ` David Rientjes
2011-08-01 10:02               ` David Rientjes
2011-08-01 12:45               ` Pekka Enberg
2011-08-01 12:45                 ` Pekka Enberg
2011-08-02  2:43                 ` David Rientjes
2011-08-02  2:43                   ` David Rientjes
2011-08-01 12:06           ` Pekka Enberg
2011-08-01 12:06             ` Pekka Enberg
2011-08-01 15:55             ` Christoph Lameter
2011-08-01 15:55               ` Christoph Lameter
2011-08-02  4:05             ` David Rientjes
2011-08-02  4:05               ` David Rientjes
2011-08-02 14:15               ` Christoph Lameter
2011-08-02 14:15                 ` Christoph Lameter
2011-08-02 16:24                 ` David Rientjes
2011-08-02 16:24                   ` David Rientjes
2011-08-02 16:36                   ` Christoph Lameter
2011-08-02 16:36                     ` Christoph Lameter
2011-08-02 20:02                     ` David Rientjes
2011-08-02 20:02                       ` David Rientjes
2011-08-03 14:09                       ` Christoph Lameter
2011-08-03 14:09                         ` Christoph Lameter
2011-08-08 20:04                         ` David Rientjes
2011-08-08 20:04                           ` David Rientjes
2011-07-30 18:27 ` Linus Torvalds
2011-07-30 18:27   ` Linus Torvalds
2011-07-30 18:32   ` Linus Torvalds
2011-07-30 18:32     ` Linus Torvalds
2011-07-31 17:39     ` Andi Kleen
2011-07-31 17:39       ` Andi Kleen
2011-08-01  0:22       ` KAMEZAWA Hiroyuki
2011-08-01  0:22         ` KAMEZAWA Hiroyuki
2011-07-31 18:11     ` David Rientjes
2011-07-31 18:11       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312145146.24862.97.camel@jaguar \
    --to=penberg@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.