From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
rientjes@google.com, hughd@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1
Date: Fri, 29 Jul 2011 16:18:37 -0700 [thread overview]
Message-ID: <m2pqksznea.fsf@firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1107291002570.16178@router.home> (Christoph Lameter's message of "Fri, 29 Jul 2011 10:04:36 -0500 (CDT)")
Christoph Lameter <cl@linux.com> writes:
> On Fri, 29 Jul 2011, Pekka Enberg wrote:
>
>> We haven't come up with a solution to keep struct page size the same but I
>> think it's a reasonable trade-off.
>
> The change requires the page struct to be aligned to a double word
> boundary.
Why is that?
> There is actually no variable added to the page struct. Its just
> the alignment requirement that causes padding to be added after each page
> struct.
These days with everyone using cgroups (and likely mcgroups too)
you could probably put the cgroups page pointer back there. It's
currently external.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
rientjes@google.com, hughd@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1
Date: Fri, 29 Jul 2011 16:18:37 -0700 [thread overview]
Message-ID: <m2pqksznea.fsf@firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1107291002570.16178@router.home> (Christoph Lameter's message of "Fri, 29 Jul 2011 10:04:36 -0500 (CDT)")
Christoph Lameter <cl@linux.com> writes:
> On Fri, 29 Jul 2011, Pekka Enberg wrote:
>
>> We haven't come up with a solution to keep struct page size the same but I
>> think it's a reasonable trade-off.
>
> The change requires the page struct to be aligned to a double word
> boundary.
Why is that?
> There is actually no variable added to the page struct. Its just
> the alignment requirement that causes padding to be added after each page
> struct.
These days with everyone using cgroups (and likely mcgroups too)
you could probably put the cgroups page pointer back there. It's
currently external.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-29 23:18 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 22:47 [GIT PULL] Lockless SLUB slowpaths for v3.1-rc1 Pekka Enberg
2011-07-28 22:47 ` Pekka Enberg
2011-07-29 15:04 ` Christoph Lameter
2011-07-29 15:04 ` Christoph Lameter
2011-07-29 23:18 ` Andi Kleen [this message]
2011-07-29 23:18 ` Andi Kleen
2011-07-30 6:33 ` Eric Dumazet
2011-07-30 6:33 ` Eric Dumazet
2011-07-31 18:50 ` David Rientjes
2011-07-31 18:50 ` David Rientjes
2011-07-31 20:24 ` David Rientjes
2011-07-31 20:24 ` David Rientjes
2011-07-31 20:45 ` Pekka Enberg
2011-07-31 20:45 ` Pekka Enberg
2011-07-31 21:55 ` David Rientjes
2011-07-31 21:55 ` David Rientjes
2011-08-01 5:08 ` Pekka Enberg
2011-08-01 5:08 ` Pekka Enberg
2011-08-01 10:02 ` David Rientjes
2011-08-01 10:02 ` David Rientjes
2011-08-01 12:45 ` Pekka Enberg
2011-08-01 12:45 ` Pekka Enberg
2011-08-02 2:43 ` David Rientjes
2011-08-02 2:43 ` David Rientjes
2011-08-01 12:06 ` Pekka Enberg
2011-08-01 12:06 ` Pekka Enberg
2011-08-01 15:55 ` Christoph Lameter
2011-08-01 15:55 ` Christoph Lameter
2011-08-02 4:05 ` David Rientjes
2011-08-02 4:05 ` David Rientjes
2011-08-02 14:15 ` Christoph Lameter
2011-08-02 14:15 ` Christoph Lameter
2011-08-02 16:24 ` David Rientjes
2011-08-02 16:24 ` David Rientjes
2011-08-02 16:36 ` Christoph Lameter
2011-08-02 16:36 ` Christoph Lameter
2011-08-02 20:02 ` David Rientjes
2011-08-02 20:02 ` David Rientjes
2011-08-03 14:09 ` Christoph Lameter
2011-08-03 14:09 ` Christoph Lameter
2011-08-08 20:04 ` David Rientjes
2011-08-08 20:04 ` David Rientjes
2011-07-30 18:27 ` Linus Torvalds
2011-07-30 18:27 ` Linus Torvalds
2011-07-30 18:32 ` Linus Torvalds
2011-07-30 18:32 ` Linus Torvalds
2011-07-31 17:39 ` Andi Kleen
2011-07-31 17:39 ` Andi Kleen
2011-08-01 0:22 ` KAMEZAWA Hiroyuki
2011-08-01 0:22 ` KAMEZAWA Hiroyuki
2011-07-31 18:11 ` David Rientjes
2011-07-31 18:11 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pqksznea.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.